From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934824AbdKPMrI convert rfc822-to-8bit (ORCPT ); Thu, 16 Nov 2017 07:47:08 -0500 Received: from 19pmail.ess.barracuda.com ([64.235.150.244]:56795 "EHLO 19pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934728AbdKPMrB (ORCPT ); Thu, 16 Nov 2017 07:47:01 -0500 From: Aleksandar Markovic To: James Hogan , Aleksandar Markovic CC: "linux-mips@linux-mips.org" , Miodrag Dinic , Goran Ferenc , "David S. Miller" , Douglas Leung , "Greg Kroah-Hartman" , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab , Paul Burton , Petar Jovanovic , Raghu Gandham , "Ralf Baechle" , Randy Dunlap Subject: RE: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based board Thread-Topic: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based board Thread-Index: AQHTXhfOlk9EmIq0B0Sx4ZGVYt9VOaMWg9yAgABte/g= Date: Thu, 16 Nov 2017 12:45:28 +0000 Message-ID: References: <1510753368-16453-1-git-send-email-aleksandar.markovic@rt-rk.com> <1510753368-16453-4-git-send-email-aleksandar.markovic@rt-rk.com>,<20171115215910.GB27409@jhogan-linux.mipstec.com> In-Reply-To: <20171115215910.GB27409@jhogan-linux.mipstec.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [82.117.201.26] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-BESS-ID: 1510836415-298553-28831-67291-1 X-BESS-VER: 2017.14-r1710272128 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.61 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186992 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound 0.60 MARKETING_SUBJECT HEADER: Subject contains popular marketing words 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH META: Sender Domain Matches Recipient Domain X-BESS-Outbound-Spam-Status: SCORE=0.61 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND, MARKETING_SUBJECT, BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: James Hogan > > Hi Aleksandar, > > On Wed, Nov 15, 2017 at 02:42:20PM +0100, Aleksandar Markovic wrote: > > diff --git a/arch/mips/configs/generic/board-ranchu.config b/arch/mips/configs/generic/board-ranchu.config > > new file mode 100644 > > index 0000000..fee9ad4 > > --- /dev/null > > +++ b/arch/mips/configs/generic/board-ranchu.config > > @@ -0,0 +1,30 @@ > > +CONFIG_VIRT_BOARD_RANCHU=y > > I presume its valid for Ranchu support to be enabled in MIPS32 / MIPS64, > and R1 / R2 / R6 kernels? (that's fine if so, just making sure there's > no need for a require comment). Yes, Ranchu virtual machine, and Android emulator for that matter, support all combinations you mentioned. > > > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c > > new file mode 100644 > > index 0000000..0efc555 > > --- /dev/null > > +++ b/arch/mips/generic/board-ranchu.c > > @@ -0,0 +1,85 @@ > > ... > > > +static __init unsigned int ranchu_measure_hpt_freq(void) > > +{ > > ... > > > + count += 5000; /* round */ > > + count -= count % 10000; > > A comment to explain the purpose of the rounding would be helpful. I > presume its there just to get a more accurate value since the frequency > will always be a round value in practice. An appropriate comment will be added in v10, but v10 will be submitted no sooner than next week, to provide enough time for other people wanting to review this and other patches. > > Either way this patch looks good to me: > Reviewed-by: James Hogan > > Thanks! > James I appreciate your review! Aleksandar