From: Aleksandar Markovic <Aleksandar.Markovic@mips.com>
To: Mathieu Malaterre <malat@debian.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Miodrag Dinic <Miodrag.Dinic@mips.com>,
Goran Ferenc <goran.ferenc@imgtec.com>,
James Hogan <jhogan@kernel.org>,
Douglas Leung <douglas.leung@imgtec.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128`
Date: Tue, 26 Dec 2017 18:10:30 +0000 [thread overview]
Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEEC28277@MIPSMAIL01.mipstec.com> (raw)
In-Reply-To: <BD3A5F1946F2E540A31AF2CE969BAEEEC2826A@MIPSMAIL01.mipstec.com>
> > Fix non-fatal warning:
> >
> > arch/mips/math-emu/dp_maddf.c:19:6: warning: no previous prototype for ‘srl128’ [-Wmissing-prototypes]
> > void srl128(u64 *hptr, u64 *lptr, int count)
> >
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > arch/mips/math-emu/dp_maddf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c
> > index 7ad79ed411f5..0e2278a47f43 100644
> > --- a/arch/mips/math-emu/dp_maddf.c
> > +++ b/arch/mips/math-emu/dp_maddf.c
> > @@ -16,7 +16,7 @@
> >
> >
> > /* 128 bits shift right logical with rounding. */
> > -void srl128(u64 *hptr, u64 *lptr, int count)
> > +static void srl128(u64 *hptr, u64 *lptr, int count)
> > {
> > u64 low;
> >
> > --
> > 2.11.0
>
> Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
However, there is an already submitted patch: (the code change is identical)
https://www.linux-mips.org/archives/linux-mips/2017-11/msg00044.html
Status of that patch on patchwork is "Accepted".
Regards,
Aleksandar
next prev parent reply other threads:[~2017-12-26 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 10:45 Mathieu Malaterre
2017-12-26 10:45 ` [PATCH 2/2] MIPS: math-emu: Declare ys variable as possibly unused Mathieu Malaterre
2017-12-26 15:12 ` Aleksandar Markovic
2017-12-27 8:40 ` Mathieu Malaterre
2017-12-26 15:14 ` [PATCH 1/2] MIPS: math-emu: Do not export function `srl128` Aleksandar Markovic
2017-12-26 18:10 ` Aleksandar Markovic [this message]
2017-12-27 8:26 ` Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BD3A5F1946F2E540A31AF2CE969BAEEEC28277@MIPSMAIL01.mipstec.com \
--to=aleksandar.markovic@mips.com \
--cc=Miodrag.Dinic@mips.com \
--cc=douglas.leung@imgtec.com \
--cc=goran.ferenc@imgtec.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®