mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liran Alon <liran.alon@oracle.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	rkrcmar@redhat.com, sean.j.christopherson@intel.com,
	vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
	joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, hpa@zytor.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] KVM: SVM: Fix potential memory leak in svm_cpu_init()
Date: Thu, 2 Jan 2020 15:22:14 +0200	[thread overview]
Message-ID: <BEE0CD6D-B921-4FFE-ADD6-76A7A170C2B0@oracle.com> (raw)
In-Reply-To: <1577931640-29420-1-git-send-email-linmiaohe@huawei.com>



> On 2 Jan 2020, at 4:20, linmiaohe <linmiaohe@huawei.com> wrote:
> 
> From: Miaohe Lin <linmiaohe@huawei.com>
> 
> When kmalloc memory for sd->sev_vmcbs failed, we forget to free the page
> held by sd->save_area.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Liran Alon <liran.alon@oracle.com>

-Liran

> ---
> arch/x86/kvm/svm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 8f1b715dfde8..89eb382e8580 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1012,7 +1012,7 @@ static int svm_cpu_init(int cpu)
> 	r = -ENOMEM;
> 	sd->save_area = alloc_page(GFP_KERNEL);
> 	if (!sd->save_area)
> -		goto err_1;
> +		goto free_cpu_data;
> 
> 	if (svm_sev_enabled()) {
> 		r = -ENOMEM;
> @@ -1020,14 +1020,16 @@ static int svm_cpu_init(int cpu)
> 					      sizeof(void *),
> 					      GFP_KERNEL);
> 		if (!sd->sev_vmcbs)
> -			goto err_1;
> +			goto free_save_area;
> 	}
> 
> 	per_cpu(svm_data, cpu) = sd;
> 
> 	return 0;
> 
> -err_1:
> +free_save_area:
> +	__free_page(sd->save_area);
> +free_cpu_data:
> 	kfree(sd);
> 	return r;
> 
> -- 
> 2.19.1
> 


  reply	other threads:[~2020-01-02 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  2:20 linmiaohe
2020-01-02 13:22 ` Liran Alon [this message]
2020-01-02 13:30 ` Vitaly Kuznetsov
2020-01-03  2:19 linmiaohe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BEE0CD6D-B921-4FFE-ADD6-76A7A170C2B0@oracle.com \
    --to=liran.alon@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®