From: Kees Cook <kees@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>,
"Artem S. Tashkinov" <aros@gmx.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, xcreativ@gmail.com,
madeisbaer@arcor.de, justinstitt@google.com,
keescook@chromium.org, linux-hardening@vger.kernel.org
Subject: Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
Date: Mon, 22 Jul 2024 00:06:59 -0700 [thread overview]
Message-ID: <BEEA84E0-1CF5-4F06-BC5C-A0F97240D76D@kernel.org> (raw)
In-Reply-To: <20240722041924.GB103010@frogsfrogsfrogs>
On July 21, 2024 9:19:24 PM PDT, "Darrick J. Wong" <djwong@kernel.org> wrote:
>On Sun, Jul 21, 2024 at 09:10:59PM +0000, Artem S. Tashkinov wrote:
>> Hello,
>>
>> There are now two bug reports containing very similar if not exactly the
>> same backtraces.
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=219072
>> https://bugzilla.kernel.org/show_bug.cgi?id=219078
>>
>> Theodore, please take a look.
>
>[adding everyone involved in 744a56389f739 ("ext4: replace deprecated
>strncpy with alternatives") to cc]
>
>Is strscpy_pad appropriate if the @src parameter itself is a fixed
>length char[16] which isn't null terminated when the label itself is 16
>chars long?
Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
-Kees
--
Kees Cook
next prev parent reply other threads:[~2024-07-22 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 21:10 Artem S. Tashkinov
2024-07-22 4:19 ` Darrick J. Wong
2024-07-22 7:06 ` Kees Cook [this message]
2024-07-23 4:11 ` Theodore Ts'o
2024-07-23 10:04 ` Thorsten Leemhuis
2024-07-23 11:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BEEA84E0-1CF5-4F06-BC5C-A0F97240D76D@kernel.org \
--to=kees@kernel.org \
--cc=aros@gmx.com \
--cc=djwong@kernel.org \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madeisbaer@arcor.de \
--cc=xcreativ@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®