From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdGUGo4 convert rfc822-to-8bit (ORCPT ); Fri, 21 Jul 2017 02:44:56 -0400 Received: from mga06.intel.com ([134.134.136.31]:23610 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbdGUGoy (ORCPT ); Fri, 21 Jul 2017 02:44:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,388,1496127600"; d="scan'208";a="1174994135" From: "Jiang, Dave" To: "Koul, Vinod" CC: Christophe JAILLET , "Williams, Dan J" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Thread-Topic: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Thread-Index: AQHTANzDqyU2gZBpd0ehm+weSEbWWqJbuPuAgAKQjoD//45qIQ== Date: Fri, 21 Jul 2017 06:44:45 +0000 Message-ID: References: <20170719221648.30253-1-christophe.jaillet@wanadoo.fr> ,<20170721063116.GK3053@localhost> In-Reply-To: <20170721063116.GK3053@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jul 20, 2017, at 11:28 PM, Koul, Vinod wrote: > >> On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote: >> >> >>> On 07/19/2017 03:16 PM, Christophe JAILLET wrote: >>> If the 'memcmp' fails, free allocated resources as done in all other >>> error handling paths. >>> >>> Signed-off-by: Christophe JAILLET > > You meant acked right..? Yes. Typo :) > >> >> Good catch! Thanks. >> >> Signed-off-by: Dave Jiang >> >>> --- >>> Please review carefully, this patch looks "too obvious" to me! >>> --- >>> drivers/dma/ioat/init.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c >>> index ed8ed1192775..948fc1f8fb5c 100644 >>> --- a/drivers/dma/ioat/init.c >>> +++ b/drivers/dma/ioat/init.c >>> @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma) >>> if (memcmp(src, dest, IOAT_TEST_SIZE)) { >>> dev_err(dev, "Self-test copy failed compare, disabling\n"); >>> err = -ENODEV; >>> - goto free_resources; >>> + goto unmap_dma; >>> } >>> >>> unmap_dma: >>> > > -- > ~Vinod