From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.247 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794937776; b=xTrTrNcx7ee/bRzSYxkpXsw9x1jp67yWzQBUG2HLJzOcNESd2iJH0DZ6Jh44hiG15jsT NEr0qErTcieyHZ4zf41E2O6iD+gA9GqmUV9P3beIpnMFGyslXhyW6MMtnX6KJJDJS+VEI VRTfyhMF5MKHFAxdkwoLqNuERleWSRozrz+C791eU4L/Ua69n1hCY1M7XFeYfSjQ2d4eW j/cVOMAPM2G53s7nhGH8bU2TFT0nc0QjwiDWIEBN7gy9NTJ7VsjtKGW5g/EQkLi9Rm+cL GTbmpcUu1wU9NfIwjjuTBuhThQKkHHbQuyMCIpRLeeTaceFaE4AGLbGfdmTHNb6wEgg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794937776; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Content-Type:Content-Transfer-Encoding: From:Mime-Version:Subject:Date:Message-Id:References:Cc:In-Reply-To: To:X-Mailer; bh=USqC8s22nHYoDzDQF9uFHHFGZ31h3DAy1gNTvMcr9dU=; b=CGaxBHpi51x4JAgkTSXeZIKaC099e2L9IZY7eWpjT26ZKdod+7owWoePoA20GjGiX8NO wKJt16tXcZnj98hy28xBqpCI+rzqQ0qhTkzRVj1KkclkfqfK/0urbZ3vBqo66JQNV6/ZB AshRdHV2cyodtMUGTNrtNNQyaFIGHiP5RA+KTY+Imbfwt9cQh8qagkXY5M1PjhYNU7wPg 9FmPua5EBvUh4DoKNcXWQ2TqgeVKfCyttyvadh//hfnZ6SfKCPcYOYQ722vpCRhWcbgpK FWK9RfqBrNFIoORYCVNcXz6V0imaOXSZDJGffU3YdTiagZsnbblunhh4h9rGidbUyNw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=YfIRHYZI; arc=none smtp.remote-ip=95.215.58.247 Received: from mta1.migadu.com (out-247.mta1.migadu.com [95.215.58.247]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C54606A32F for ; Tue, 17 Nov 2026 17:49:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 81C54606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=YfIRHYZI X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=4nUZbHSGDeC5EzVQv/op9L9Mno790WzQ1pC5Hx0vt5Q=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794937773; v=1; x=1795542573; b=YfIRHYZI1UkGKEdWhq1EsKsV9sJ5TYB/Zor6pnppHWXMR+Tfw/P0oJtiSJ90IDue4AnhNKo3 PTSTnowS2ll+bQhIUgVIX0Z0CEMV8bc+3svVjImk9HUApeCyBM10uA5XI/AVJ3L2ZgtHwzuMnPV uukKNDjFQs7JjM74a0TimTCc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta12.migadu.com with ESMTPS id 4b46ce5bd6d34d3e; Tue, 17 Nov 2026 17:49:33 +0000 X-Mizu-Trace-ID: 4b46ce5bd6d34d3e X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Aditya Garg X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips Date: Tue, 17 Nov 2026 23:19:18 +0530 Message-Id: References: <20261116203719.281605-3-arend.vanspriel@broadcom.com> Cc: Andre Eikmeyer , arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Yossef Osman In-Reply-To: <20261116203719.281605-3-arend.vanspriel@broadcom.com> To: Arend van Spriel X-Mailer: iPad Mail (24B119) > On 17 Nov 2026, at 2:07=E2=80=AFAM, Arend van Spriel wrote: >=20 > =EF=BB=BFOn Wed, 4 Nov 2026 16:16:29 +0100, Andre Eikmeyer = wrote: >> The Apple firmware for the BCM4364 and BCM4377 lists "idauth" in its >> capabilities, so brcmfmac enables BRCMF_FEAT_FWAUTH and advertises >> NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK. hostapd and wpa_supplicant >> then pass the PSK to the driver and leave the AP side of the 4-way >> handshake to the firmware. On the BCM4364 that handshake never >> completes. >>=20 >> [...] >>=20 >> Clear BRCMF_FEAT_FWAUTH on the chips in Apple's T2 Macs, so the host >> runs the handshake. >=20 > [...] >=20 >> --- >> .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >=20 >> @@ -318,6 +318,20 @@ void brcmf_feat_attach(struct brcmf_pub *drvr) >> BIT(BRCMF_FEAT_WOWL_GTK); >> } >> } >> + /* The Apple firmware for these chips lists "idauth", but in AP mode= >> + * its authenticator never completes the 4-way handshake and the >> + * station is dropped after about 8 s. Leave the handshake to the ho= st. >> + */ >> + switch (drvr->bus_if->chip) { >> + case BRCM_CC_4355_CHIP_ID: >> + case BRCM_CC_4364_CHIP_ID: >> + case BRCM_CC_4377_CHIP_ID: >> + ifp->drvr->feat_flags &=3D ~BIT(BRCMF_FEAT_FWAUTH); >> + break; >> + default: >> + break; >> + } >> + >> /* MBSS does not work for all chips */ >> switch (drvr->bus_if->chip) { >=20 > The commit message and the test report only cover BCM4364 and BCM4377, > but the code also clears FWAUTH for BCM4355. Where does that come from? > Was it tested, and is BCM4355 found in T2 Macs? If not, please drop it > or justify it. 4355 is also a Mac specific chip found in MacBookAir8,1 and 8,2. I'm actuall= y surprised you forgot about that especially when there was a whole issue wh= en Cypress named their chip firmware wrongly as 4355. >=20 > The chip ID check has the same problem as in the ARP/ND offload patch [1]:= > the issue is described as specific to the Apple firmware, but the quirk > applies to every BCM4355, BCM4364 and BCM4377, and those users would lose > offloaded AP PSK. Please restrict it as suggested there. >=20 > Note that BRCMF_FEAT_FWAUTH is required for NL80211_EXT_FEATURE_SAE_OFFLOA= D_AP > in brcmf_setup_wiphy(). Please mention in the commit message whether > that is affected on these chips (i.e. whether the firmware offers "sae" > at all) or confirm it is intentionally dropped too. >=20 > Have you looked at the actual root cause (e.g. missing/incorrect > "idauth" related iovars such as setting the PMK or wsec_info for AP on > this firmware)? If the offload is never usable on these firmwares, say > so in the commit message with reference to the firmware version(s) > checked. >=20 > [...] >=20 > Minor: please add the target tree to the subject (wifibot series_format > warning). >=20 > [1] https://lore.kernel.org/all/20261104151620.70671-1-dev@deq.rocks/ >=20 > Regards, > Arend