mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mikael Starvik" <mikael.starvik@axis.com>
To: "'Eric W. Biederman'" <ebiederm@xmission.com>,
	"'Andrew Morton'" <akpm@osdl.org>
Cc: "'Linus Torvalds'" <torvalds@osdl.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/23] Fix the arguments to machine_restart on cris
Date: Mon, 15 Aug 2005 11:24:31 +0200	[thread overview]
Message-ID: <BFECAF9E178F144FAEF2BF4CE739C668030B4DC3@exmail1.se.axis.com> (raw)
In-Reply-To: <BFECAF9E178F144FAEF2BF4CE739C668031D51FB@exmail1.se.axis.com>

Well, not really luck but anyway (the caller puts the first argument in
register r10 and the called function never uses it so no harm).

Acked-by: Mikael Starvik <starvik@axis.com>

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Eric W. Biederman
Sent: Tuesday, July 26, 2005 7:33 PM
To: Andrew Morton
Cc: Linus Torvalds; linux-kernel@vger.kernel.org
Subject: [PATCH 5/23] Fix the arguments to machine_restart on cris



It appears machine_restart has been working cris just
by luck.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---

 arch/cris/kernel/process.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

bb30d3f0b58c6ecde77e7446b8bab12610fb5f97
diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
--- a/arch/cris/kernel/process.c
+++ b/arch/cris/kernel/process.c
@@ -113,6 +113,7 @@
 #include <linux/user.h>
 #include <linux/elfcore.h>
 #include <linux/mqueue.h>
+#include <linux/reboot.h>
 
 //#define DEBUG
 
@@ -208,7 +209,7 @@ void cpu_idle (void)
 
 void hard_reset_now (void);
 
-void machine_restart(void)
+void machine_restart(char *cmd)
 {
 	hard_reset_now();
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


       reply	other threads:[~2005-08-15  9:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BFECAF9E178F144FAEF2BF4CE739C668031D51FB@exmail1.se.axis.com>
2005-08-15  9:24 ` Mikael Starvik [this message]
2005-07-26 17:19 [PATCH 0/23] reboot-fixes Eric W. Biederman
2005-07-26 17:21 ` [PATCH 1/23] Add missing device_suspsend(PMSG_FREEZE) calls Eric W. Biederman
2005-07-26 17:24   ` [PATCH 2/23] Refactor sys_reboot into reusable parts Eric W. Biederman
2005-07-26 17:27     ` [PATCH 3/23] Make ctrl_alt_del call kernel_restart to get a proper reboot Eric W. Biederman
2005-07-26 17:29       ` [PATCH 4/23] Add emergency_restart() Eric W. Biederman
2005-07-26 17:32         ` [PATCH 5/23] Fix the arguments to machine_restart on cris Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BFECAF9E178F144FAEF2BF4CE739C668030B4DC3@exmail1.se.axis.com \
    --to=mikael.starvik@axis.com \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®