From: Joe Xue <lgxue@hotmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "cooloney@gmail.com" <cooloney@gmail.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"rob@landley.net" <rob@landley.net>,
"milo.kim@ti.com" <milo.kim@ti.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH] Add LED pattern trigger
Date: Tue, 31 Dec 2013 13:48:50 -0500 [thread overview]
Message-ID: <BLU172-W451DF59115DB2B0A7F694AACC90@phx.gbl> (raw)
In-Reply-To: <20131230162158.7420e811@alan.etchedpixels.co.uk>
>> + * Based on Richard Purdie's ledtrig-timer.c and Atsushi Nemoto's
>> + * ledtrig-heartbeat.c and Shuah Khan's ledtrig-transient.c
>
> I stil think this belongs in user space except for platforms with hardware
> acceleration for it.
This can free the user space application from loop or thread.
>> +#define MAX_PATTEN_LEN 255
>
> Arbitary limits that are not needed if it was in userspace, and not it
> seems a sensible one - why not use 256 ?
Yes, will change it to kmalloc
>> +static DEVICE_ATTR(pattern, 0644, pattern_pattern_show, pattern_pattern_store);
>> +static DEVICE_ATTR(delay_unit, 0644,
>> +static void pattern_trig_deactivate(struct led_classdev *led_cdev)
>> +{
>> + struct pattern_trig_data *pattern_data = led_cdev->trigger_data;
>> +
>> + if (led_cdev->activated) {
>> + del_timer_sync(&pattern_data->timer);
>> + device_remove_file(led_cdev->dev, &dev_attr_pattern);
>> + device_remove_file(led_cdev->dev, &dev_attr_delay_unit);
>
> This doesn't as far as I can see do what you think. If I have the file
> currently open then device_remove_file will not remove my existing access
> to it, but you just released the pattern data so I now write to free
> memory.
will add the mutex lock to avoid that
next prev parent reply other threads:[~2013-12-31 18:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 0:11 Joe Xue
2013-12-30 16:21 ` One Thousand Gnomes
2013-12-30 23:24 ` Joe Xue
2013-12-31 0:18 ` One Thousand Gnomes
2013-12-31 18:48 ` Joe Xue [this message]
2014-01-01 20:10 ` One Thousand Gnomes
2014-01-01 22:44 ` David Lang
2014-01-01 23:01 ` One Thousand Gnomes
2014-01-01 23:51 ` David Lang
2014-01-03 0:14 ` Bryan Wu
2014-01-03 9:33 ` Richard Weinberger
2014-01-03 15:23 ` One Thousand Gnomes
2014-01-05 22:23 ` n900 led compiler (was Re: [PATCH] Add LED pattern trigger) Pavel Machek
2014-01-07 15:40 ` Linus Walleij
2013-12-30 18:33 ` [PATCH] Add LED pattern trigger Pavel Machek
2013-12-31 5:00 ` Joe Xue
2013-12-31 11:33 ` Pavel Machek
2013-12-31 12:29 ` Richard Weinberger
2013-12-31 19:03 ` Pavel Machek
2014-01-01 20:11 ` One Thousand Gnomes
2014-01-01 2:57 ` [PATCH v2 1/1] leds: " Joe Xue
2014-01-01 3:03 ` [PATCH v2 1/1] " Joe Xue
2014-01-06 21:47 ` [PATCH v3 1/1] leds: " lgxue
2014-01-06 22:10 ` Joe Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLU172-W451DF59115DB2B0A7F694AACC90@phx.gbl \
--to=lgxue@hotmail.com \
--cc=cooloney@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=pavel@ucw.cz \
--cc=rob@landley.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®