From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbbDDVsN (ORCPT ); Sat, 4 Apr 2015 17:48:13 -0400 Received: from blu004-omc1s26.hotmail.com ([65.55.116.37]:52239 "EHLO BLU004-OMC1S26.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbbDDVsM (ORCPT ); Sat, 4 Apr 2015 17:48:12 -0400 X-TMN: [WniPkUdLtxIdty20xQNUdlMWT1TTM6LX] X-Originating-Email: [xili_gchen_5257@hotmail.com] Message-ID: Date: Sun, 5 Apr 2015 05:48:11 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Richard Weinberger CC: "realmz6@gmail.com" , "adi-buildroot-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] blackfin: Kconfig: Let PLL_BYPASS and MPU depend on some BF_REV of BF533 References: In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 04 Apr 2015 21:48:10.0818 (UTC) FILETIME=[0B509A20:01D06F21] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/15 06:59, Richard Weinberger wrote: > On Thu, Apr 2, 2015 at 11:25 PM, Chen Gang wrote: >> For allmodconfig, it uses BF533 which will cause 3 issues for common >> checking: >> >> - The first 2 issues are about PLL_BYPASS, it needs BF_REV_0_6 (which >> just match the compiler's output for __SILICON_REVISION__). >> >> - The last issue is about MPU, it needs BF_REV_0_5 or BF_REV_0_6 (which >> just match the compiler's output for __SILICON_REVISION__). >> >> The related error with allmodconfig: >> >> CC arch/blackfin/mach-common/arch_checks.o >> arch/blackfin/mach-common/arch_checks.c:24:3: error: #error "Sclk value selected is less than minimum. Please select a proper value for SCLK multiplier" >> # error "Sclk value selected is less than minimum. Please select a proper value for SCLK multiplier" >> ^ >> arch/blackfin/mach-common/arch_checks.c:28:3: error: #error "ANOMALY 05000273, please make sure CCLK is at least 2x SCLK" >> # error "ANOMALY 05000273, please make sure CCLK is at least 2x SCLK" >> ^ >> arch/blackfin/mach-common/arch_checks.c:51:3: error: #error the MPU will not function safely while Anomaly 05000263 applies >> # error the MPU will not function safely while Anomaly 05000263 applies >> ^ >> >> config PLL_BYPASS >> bool "Bypass PLL" >> - depends on BFIN_KERNEL_CLOCK && (!BF60x) >> + depends on BFIN_KERNEL_CLOCK && (!BF60x) && ((!BF533) || BF_REV_0_6) >> default n >> >> config CLKIN_HALF >> @@ -1112,6 +1112,7 @@ endchoice >> comment "Memory Protection Unit" >> config MPU >> bool "Enable the memory protection unit" >> + depends on (!BF533) || BF_REV_0_6 || BF_REV_0_5 >> default n >> help >> Use the processor's MPU to protect applications from accessing > > This answers my question wrt. allmodconfig. ;) > I'm not sure if this is the correct way. Isn't this the reason why we > have COMPILE_TEST? > For me, COMPILE_TEST is for compiling test without the related hardware supports, but the code should no any logical issues firstly (at least, COMPILE_TEST itself should not generate additional logical bugs). In our case, I guess the first 2 issues are about logical issues (not hardware supporting issues), so I guess, it is not suitable to use COMPILE_TEST to bypass them. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed