From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982AbbDDV3n (ORCPT ); Sat, 4 Apr 2015 17:29:43 -0400 Received: from blu004-omc3s24.hotmail.com ([65.55.116.99]:62375 "EHLO BLU004-OMC3S24.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbbDDV3m (ORCPT ); Sat, 4 Apr 2015 17:29:42 -0400 X-TMN: [FpzxMeG2Yv4M6rnGRSm+uaEgZbG3ufKm] X-Originating-Email: [xili_gchen_5257@hotmail.com] Message-ID: Date: Sun, 5 Apr 2015 05:29:40 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Richard Weinberger , Richard Weinberger CC: realmz6@gmail.com, "adi-buildroot-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] blackfin: Makefile: Add -D__linux__ flag for KBUILD_CFLAGS References: <552054DF.4090604@nod.at> In-Reply-To: <552054DF.4090604@nod.at> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 04 Apr 2015 21:29:40.0772 (UTC) FILETIME=[75AD0640:01D06F1E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/15 05:17, Richard Weinberger wrote: > Am 04.04.2015 um 23:13 schrieb Chen Gang: >> Is what I have done above correct? Or can we treate it as gcc's issue? > > At least ask gcc folks about that before you add a random hack to the kernel. > For the latest compiler, it should contents -D__linux__, and what I have done for building gcc/binutils is the common way, so I guess binutils or gcc need improvement (I shall try to fix it within this month). But, I am not quite sure whether the old version bfin compilers also supports -D__linux__ (comparing some of the old compilers of the other archs, I guess not). Are you sure the old version bfin compilers are OK? BTW, for the latest bfin compiler from upstream, it contents another issues which I bypassed now. I shall try to fix them within this month (try to send all fix patches v1 within 2015-04-20). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed