From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbbIGFVr (ORCPT ); Mon, 7 Sep 2015 01:21:47 -0400 Received: from blu004-omc2s11.hotmail.com ([65.55.111.86]:55315 "EHLO BLU004-OMC2S11.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbbIGFVp (ORCPT ); Mon, 7 Sep 2015 01:21:45 -0400 X-TMN: [kVdtSO0CCoWmWXon7KKFCuEsxOKgRC9e] X-Originating-Email: [wanpeng.li@hotmail.com] Message-ID: Subject: Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch To: Srikar Dronamraju References: <1439290813-6683-1-git-send-email-srikar@linux.vnet.ibm.com> <1439310261-16124-1-git-send-email-srikar@linux.vnet.ibm.com> <20150907041001.GA7066@linux.vnet.ibm.com> CC: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Rik van Riel , Mel Gorman From: Wanpeng Li Date: Mon, 7 Sep 2015 13:21:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150907041001.GA7066@linux.vnet.ibm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Sep 2015 05:21:43.0789 (UTC) FILETIME=[1589B1D0:01D0E92D] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/15 12:10 PM, Srikar Dronamraju wrote: > * Wanpeng Li [2015-09-06 12:01:10]: > > > Hi Wanpeng Li, > > >> Hi Srikar, >> On 8/12/15 12:24 AM, Srikar Dronamraju wrote: >>> Variable sched_numa_balancing toggles numa_balancing feature. Hence >>> moving from a simple read mostly variable to a more apt static_branch. >>> >>> Suggested-by: Peter Zijlstra >>> Signed-off-by: Srikar Dronamraju >>> >> This commit breaks Peter's queue: >> >> kernel/sched/fair.c: In function ?task_numa_fault?: >> kernel/sched/fair.c:2072: error: implicit declaration of function >> ?static_branch_likely? >> kernel/sched/fair.c: In function ?task_tick_fair?: >> kernel/sched/fair.c:7867: error: implicit declaration of function >> ?static_branch_unlikely? >> make[1]: *** [kernel/sched/fair.o] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> kernel/sched/core.c:2116: warning: data definition has no type or storage >> class > Thanks for reporting. Can you please confirm if you have the commit > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61 It seems that the sched/core branch of Peterz's queue doesn't include this commit. So your patch should be good. Regards, Wanpeng Li