From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753395AbbGFCcq (ORCPT ); Sun, 5 Jul 2015 22:32:46 -0400 Received: from blu004-omc3s7.hotmail.com ([65.55.116.82]:52949 "EHLO BLU004-OMC3S7.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbbGFCcj (ORCPT ); Sun, 5 Jul 2015 22:32:39 -0400 X-TMN: [1Ht/sIYMuOinrKnUvP+I0JnC9N1YJYZ/] X-Originating-Email: [xili_gchen_5257@hotmail.com] Message-ID: Date: Mon, 6 Jul 2015 10:32:16 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Rothwell , Geert Uytterhoeven CC: Greg KH , Simon Horman , cj@linux.com, Geert Uytterhoeven , Jesper Nilsson , Mikael Starvik , driverdevel , "linux-kernel@vger.kernel.org" , Paul Gortmaker Subject: Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP References: <20150706084801.2995face@canb.auug.org.au> In-Reply-To: <20150706084801.2995face@canb.auug.org.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Jul 2015 02:32:37.0036 (UTC) FILETIME=[0593CEC0:01D0B794] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2015 06:48 AM, Stephen Rothwell wrote: > Hi all, > > On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven wrote: >> >> On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang wrote: >>> It needs clk_add_alias() from clk drivers, which is implemented in >>> "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP. >>> >>> Normally, archs and clk driver its own will decide whether select >>> CLKDEV_LOOKUP, and common drivers will decide whether depend on it. >>> >>> The related error (with allmodconfig under cris for next-20150702): >>> >>> drivers/built-in.o: In function `board_staging_register_clock': >>> drivers/staging/board/board.c:131: undefined reference to `clk_add_alias' >>> >>> >>> Signed-off-by: Chen Gang >> >> Fix available for the last 15 days: >> >> https://lkml.org/lkml/2015/6/20/215 > > I added Chen's patch to my fixes tree today (only because I couldn't > easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a > full mail message from lkml.org? Or Geert, maybe that is not the best > place to link to. > For me, I still suggest to use Paul's patch (if it is OK, too). He sent the patch more than 10 days, and was still waiting patiently. There will be a little more work, but I guess, it is necessary. And I shall try to send another patches for Linux kernel. :-) Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed