From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751229AbbIFEGY (ORCPT <rfc822;w@1wt.eu>);
	Sun, 6 Sep 2015 00:06:24 -0400
Received: from blu004-omc2s28.hotmail.com ([65.55.111.103]:56304 "EHLO
	BLU004-OMC2S28.hotmail.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751146AbbIFEGS convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 6 Sep 2015 00:06:18 -0400
X-Greylist: delayed 300 seconds by postgrey-1.27 at vger.kernel.org; Sun, 06 Sep 2015 00:06:18 EDT
X-TMN: [JJqlbX06lBKA55zGCLEAC4Ulmyy4YiKP]
X-Originating-Email: [wanpeng.li@hotmail.com]
Message-ID: <BLU437-SMTP64B481445D8E303ABE0D4D80550@phx.gbl>
Subject: Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a
 static_branch
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
References: <1439290813-6683-1-git-send-email-srikar@linux.vnet.ibm.com>
 <1439310261-16124-1-git-send-email-srikar@linux.vnet.ibm.com>
CC: linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
        Mel Gorman <mgorman@suse.de>
From: Wanpeng Li <wanpeng.li@hotmail.com>
Date: Sun, 6 Sep 2015 12:01:10 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1439310261-16124-1-git-send-email-srikar@linux.vnet.ibm.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 8BIT
X-OriginalArrivalTime: 06 Sep 2015 04:01:16.0431 (UTC) FILETIME=[ADCB91F0:01D0E858]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Srikar,
On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
> Variable sched_numa_balancing toggles numa_balancing feature. Hence
> moving from a simple read mostly variable to a more apt static_branch.
>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
This commit breaks Peter's queue:

kernel/sched/fair.c: In function ‘task_numa_fault’:
kernel/sched/fair.c:2072: error: implicit declaration of function 
‘static_branch_likely’
kernel/sched/fair.c: In function ‘task_tick_fair’:
kernel/sched/fair.c:7867: error: implicit declaration of function 
‘static_branch_unlikely’
make[1]: *** [kernel/sched/fair.o] Error 1
make[1]: *** Waiting for unfinished jobs....
kernel/sched/core.c:2116: warning: data definition has no type or 
storage class
kernel/sched/core.c:2116: error: type defaults to ‘int’ in declaration 
of ‘DEFINE_STATIC_KEY_FALSE’
kernel/sched/core.c:2116: warning: parameter names (without types) in 
function declaration
kernel/sched/core.c: In function ‘set_numabalancing_state’:
kernel/sched/core.c:2123: error: implicit declaration of function 
‘static_branch_enable’
kernel/sched/core.c:2125: error: implicit declaration of function 
‘static_branch_disable’
kernel/sched/core.c: In function ‘sysctl_numa_balancing’:
kernel/sched/core.c:2134: error: implicit declaration of function 
‘static_branch_likely’
make[1]: *** [kernel/sched/core.o] Error 1
make: *** [kernel/sched/] Error 2

Regards,
Wanpeng Li