From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbdK3RLJ convert rfc822-to-8bit (ORCPT ); Thu, 30 Nov 2017 12:11:09 -0500 Received: from mail-dm3nam03on0096.outbound.protection.outlook.com ([104.47.41.96]:44384 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753105AbdK3RLI (ORCPT ); Thu, 30 Nov 2017 12:11:08 -0500 From: Hartley Sweeten To: Lukasz Majewski , Alexander Sverdlin , Arnd Bergmann , "arndbergmann@gmail.com" CC: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Olof Johansson , "Linus Walleij" Subject: RE: [PATCH v3 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable Thread-Topic: [PATCH v3 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable Thread-Index: AQHTaXSLZn8gRjupu0eHz35RmjXaZ6MtKNUg Date: Thu, 30 Nov 2017 17:11:05 +0000 Message-ID: References: <20171116232239.16823-1-lukma@denx.de> <20171130004510.23887-1-lukma@denx.de> <20171130004510.23887-5-lukma@denx.de> In-Reply-To: <20171130004510.23887-5-lukma@denx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [63.230.248.202] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BLUPR0101MB1556;6:2fdyUZovPf4VFwXrTn6uSfYQtuu0t5Mtqyw+3ovyTcNk6b7mtDZvXFlhGrHRllXia4Nn+hIdNADA7FDn6iUjb2X3dak1xZpko8/gadExWk9a8GPIAw/z+PgC46UHaxy+kEwZoLy+oENIyHsTZaUwQelfW4tcQF9gcYogLmozCOH6j5x4UICx6CUBu471Lt3jLEK6Glw1X78aA/5IpZG3q4Cx8u+GXQGDDxPSVZ43x9Id1XNYBzh6W9Rql22lOOZBpRl5s1KwouCx1Scp4/gmwnPjPACgzn4mFqEA4kn2TezgKDopJzQ2S/9LQmMZy2EKVgepi6KEjxdWChp3Mtgfi6Khp6Y+EaNxL+DkFbXlXHY=;5:B6v74cwJk4WEG0MtgV7TmBWib84RNd/ymdQcVieUUbaRBcZTZ6mhFmUjYHP5XKKrlbwIygGgt5jSNHilbRl8sLD70lVbMasrAFXclpn/olaKKKJc3s1UhD42w3KDWhXLZlA66D7r5N/J1IHKkzWLjflHVoZhF1Q43T1JaYTZmCg=;24:Ei2fs5+kbZyl2/R2gw99S221AC4zkUwWzRECTX1NF9unqTh4UfbU71emZOAii5Ei83v+zWKjaFW2z6125uf1T/K2slK59mq5CUHBXiWH1gE=;7:VqWfIVRFh3nb55QRT9BVxilEzGjze3FXDUCWB/FZDNi/FytVG6gfGWJ5icdeBuvB6BSQWh6lNo7vEWT2Td2cyRcJ/j3g2c5hXLuB36XkrVQj0NiNTgzMC4uct0QNOiKP14GZE9FZXwvZvu4Nvo4pVqJbaZxlRaUW+tG2IiW7Y78Uq0DupwctyC1mzF4jw1cQRqPdU7PzIbfkVv4vSEue1ENPFRRBswepovErRGcJt6fNb/BCckCqhcZkANHIiCYR x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: c3474e65-634e-4664-1692-08d5381557b0 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603286);SRVR:BLUPR0101MB1556; x-ms-traffictypediagnostic: BLUPR0101MB1556: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(2016111802025)(6072148)(6043046)(201708071742011);SRVR:BLUPR0101MB1556;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BLUPR0101MB1556; x-forefront-prvs: 05079D8470 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(366004)(376002)(24454002)(189002)(199003)(99286004)(8936002)(105586002)(5660300001)(7736002)(33656002)(2501003)(101416001)(305945005)(2906002)(81166006)(106356001)(3280700002)(55016002)(8676002)(81156014)(189998001)(229853002)(9686003)(6506006)(2900100001)(3660700001)(77096006)(6436002)(53936002)(3846002)(66066001)(74316002)(4326008)(68736007)(25786009)(6246003)(39060400002)(102836003)(478600001)(14454004)(72206003)(6116002)(53546010)(316002)(7696005)(575784001)(86362001)(54356010)(97736004)(76176010)(50986010)(2950100002)(54906003)(110136005)(80792005);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR0101MB1556;H:BLUPR0101MB1554.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3474e65-634e-4664-1692-08d5381557b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2017 17:11:05.6919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0101MB1556 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > The map IO common code has been excluded to be reused by other ts72xx clones. > > Signed-off-by: Lukasz Majewski > Acked-by: Alexander Sverdlin > arch/arm/mach-ep93xx/ts72xx.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/ts72xx.c b/arch/arm/mach-ep93xx/ts72xx.c index 00e0e5b8babf..a6e473b3dcf6 100644 > --- a/arch/arm/mach-ep93xx/ts72xx.c > +++ b/arch/arm/mach-ep93xx/ts72xx.c > @@ -30,11 +30,6 @@ > > static struct map_desc ts72xx_io_desc[] __initdata = { > { > - .virtual = (unsigned long)TS72XX_MODEL_VIRT_BASE, > - .pfn = __phys_to_pfn(TS72XX_MODEL_PHYS_BASE), > - .length = TS72XX_MODEL_SIZE, > - .type = MT_DEVICE, > - }, { > .virtual = (unsigned long)TS72XX_OPTIONS_VIRT_BASE, > .pfn = __phys_to_pfn(TS72XX_OPTIONS_PHYS_BASE), > .length = TS72XX_OPTIONS_SIZE, > @@ -47,12 +42,26 @@ static struct map_desc ts72xx_io_desc[] __initdata = { > } > }; > > -static void __init ts72xx_map_io(void) > +static struct map_desc ts72xx_common_io_desc[] __initdata = { > + { > + .virtual = (unsigned long)TS72XX_MODEL_VIRT_BASE, > + .pfn = __phys_to_pfn(TS72XX_MODEL_PHYS_BASE), > + .length = TS72XX_MODEL_SIZE, > + .type = MT_DEVICE, > + } > +}; > + > +void __init ts72xx_common_map_io(void) > { > ep93xx_map_io(); > - iotable_init(ts72xx_io_desc, ARRAY_SIZE(ts72xx_io_desc)); > + iotable_init(ts72xx_common_io_desc, There is a trailing whitespace on the line above. > +ARRAY_SIZE(ts72xx_common_io_desc)); This line is missing an indent. > } > > +static void __init ts72xx_map_io(void) > +{ > + ts72xx_common_map_io(); > + iotable_init(ts72xx_io_desc, ARRAY_SIZE(ts72xx_io_desc)); } > > /************************************************************************* > * NAND flash Hartley