From: Chen Wang <unicorn_wang@outlook.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Chen Wang <unicornxw@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
inochiama@outlook.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-riscv@lists.infradead.org, chao.wei@sophgo.com,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
chunzhi.lin@sophgo.com, Sean Young <sean@mess.org>
Subject: Re: [PATCH v6 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM
Date: Wed, 22 Jan 2025 19:54:26 +0800 [thread overview]
Message-ID: <BM1PR01MB254554818778F4EC9449EC68FEE12@BM1PR01MB2545.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <dlnfivdhol7faotaqygpvdi2zbgpwrvcruppbkgfleoa6msxib@voe7dhqvfmy6>
On 2025/1/22 18:03, Uwe Kleine-König wrote:
> The rational is usually that
>
> mul_u64_u64_div_u64(ddata->clk_rate_hz, state->period, NSEC_PER_SEC)
>
> cannot overflow. Your driver relies on that, too. (Which somewhat
> proves that a comment is indeed necessary 🙂
Oh, thanks for pointing that out, I almost forgot about that. Will check
this out in the next version.
Regards,
Chen
next prev parent reply other threads:[~2025-01-22 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 3:15 [PATCH v6 0/3] pwm: Add pwm driver for Sophgo SG2042 Chen Wang
2024-12-04 3:16 ` [PATCH v6 1/3] dt-bindings: pwm: sophgo: add PWM controller for SG2042 Chen Wang
2025-01-21 11:16 ` Uwe Kleine-König
2025-01-22 8:21 ` Chen Wang
2024-12-04 3:17 ` [PATCH v6 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM Chen Wang
2025-01-21 11:14 ` Uwe Kleine-König
2025-01-22 8:58 ` Chen Wang
2025-01-22 10:03 ` Uwe Kleine-König
2025-01-22 11:54 ` Chen Wang [this message]
2024-12-04 3:17 ` [PATCH v6 3/3] riscv: sophgo: dts: add pwm controller for SG2042 SoC Chen Wang
2024-12-04 3:23 ` [PATCH v6 0/3] pwm: Add pwm driver for Sophgo SG2042 Chen Wang
2025-01-07 0:15 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BM1PR01MB254554818778F4EC9449EC68FEE12@BM1PR01MB2545.INDPRD01.PROD.OUTLOOK.COM \
--to=unicorn_wang@outlook.com \
--cc=chao.wei@sophgo.com \
--cc=chunzhi.lin@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sean@mess.org \
--cc=ukleinek@kernel.org \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®