From: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
Hyun Kwon <hyunk@xilinx.com>
Subject: RE: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to xlnx_vcu driver
Date: Wed, 13 Dec 2017 05:12:23 +0000 [thread overview]
Message-ID: <BY2PR0201MB1879663CDB18630B31A00F2AC1350@BY2PR0201MB1879.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20171212200703.nxabyfcjbswwbp4v@rob-hp-laptop>
Hi Rob,
Thanks a lot for the review.
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, December 12, 2017 12:07 PM
> To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> Cc: arnd@arndb.de; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; mark.rutland@arm.com;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> michal.simek@xilinx.com; Hyun Kwon <hyunk@xilinx.com>; Dhaval
> Rajeshbhai Shah <DSHAH@xilinx.com>
> Subject: Re: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to
> xlnx_vcu driver
>
> On Thu, Dec 07, 2017 at 01:31:15PM -0800, Dhaval Shah wrote:
> > Add Device Tree binding document for logicoreIP. This logicoreIP
> > provides the isolation between the processing system and programmable
> > logic. Also provides the clock related information.
> >
> > Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> > ---
> > Changes since v2:
> > * Describe the h/w
> > * compatible string is updated to make it more specific
> > based on the logicoreIP version.
> > * Removed that encoder and decoder child nodes and relatd properties as
> that
> > will be a separate driver and dts nodes. other team is working on that.
> > * Updated to use as a single driver.
> >
> > .../devicetree/bindings/misc/xlnx,vcu.txt | 31
> ++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,vcu.txt
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> One nit. Use "dt-bindings: misc: ..." for the subject.
I will update subject line and send you v3 patch set.
next prev parent reply other threads:[~2017-12-13 5:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 11:43 [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver Dhaval Shah
2017-12-05 12:18 ` Arnd Bergmann
2017-12-05 12:38 ` Dhaval Rajeshbhai Shah
2017-12-05 13:32 ` Arnd Bergmann
2017-12-06 5:44 ` Dhaval Rajeshbhai Shah
2017-12-05 13:30 ` Greg KH
2017-12-06 6:01 ` Dhaval Rajeshbhai Shah
2017-12-06 7:56 ` 'Greg KH'
2017-12-06 9:05 ` Dhaval Rajeshbhai Shah
2017-12-06 9:15 ` 'Greg KH'
2017-12-06 9:38 ` Dhaval Rajeshbhai Shah
2017-12-07 10:06 ` Philippe Ombredanne
2017-12-07 10:30 ` Dhaval Rajeshbhai Shah
2017-12-07 10:47 ` Greg Kroah-Hartman
2017-12-07 21:31 ` [PATCH v2 0/2] Documentation and driver of logicoreIP Dhaval Shah
2017-12-07 21:31 ` [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to xlnx_vcu driver Dhaval Shah
2017-12-12 20:07 ` Rob Herring
2017-12-13 5:12 ` Dhaval Rajeshbhai Shah [this message]
2017-12-07 21:31 ` [PATCH v2 2/2] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver Dhaval Shah
2017-12-07 21:47 ` Philippe Ombredanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY2PR0201MB1879663CDB18630B31A00F2AC1350@BY2PR0201MB1879.namprd02.prod.outlook.com \
--to=dshah@xilinx.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hyunk@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pombredanne@nexb.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®