From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758109AbcHWO2X (ORCPT ); Tue, 23 Aug 2016 10:28:23 -0400 Received: from mail-by2nam03on0074.outbound.protection.outlook.com ([104.47.42.74]:26391 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758044AbcHWO2W (ORCPT ); Tue, 23 Aug 2016 10:28:22 -0400 From: Bart Van Assche To: Mikko Rapeli , "linux-kernel@vger.kernel.org" CC: "dm-devel@redhat.com" , Mike Snitzer , Alasdair Kergon Subject: Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Thread-Topic: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Thread-Index: AQHR/UY8kS9VH3eavE6uuEqP0WFEag== Date: Tue, 23 Aug 2016 14:28:19 +0000 Message-ID: References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-5-git-send-email-mikko.rapeli@iki.fi> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@sandisk.com; x-originating-ip: [73.15.202.106] x-ms-office365-filtering-correlation-id: 58be631f-d0bb-4230-a0f5-08d3cb61baa8 x-microsoft-exchange-diagnostics: 1;BY2PR02MB1686;20:wkJaCY4N+2JLsulD/yEbyEqCuvaPnzSiDI7IdOV1+PZtAwAhCQZJigBuSvG5SI6rLZt/vRtGgVevo/cAwmM0TgbL0h+yQbvhIe9t6vf+yRRaw6njmMiKOfOoZ61/UhSCbHw8PamVRB/eNvra4PgstRM0rnCrP/XJr7cG/O9XDAXSNs34VeBGR0aStzNDtukvThGFYqxyCIsyTxMNYAbvG0GHplyXn6N3EwsLV+AgASq4A+kRMInRHtcgGmbjtNzl x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1686; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BY2PR02MB1686;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1686; x-forefront-prvs: 004395A01C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(24454002)(199003)(54356999)(4326007)(6116002)(3846002)(2906002)(2900100001)(5002640100001)(586003)(86362001)(77096005)(102836003)(97736004)(5001770100001)(68736007)(105586002)(189998001)(92566002)(99286002)(230783001)(2501003)(122556002)(33656002)(11100500001)(9686002)(3660700001)(3280700002)(106356001)(81166006)(8676002)(87936001)(74316002)(66066001)(5660300001)(81156014)(106116001)(101416001)(10400500002)(8936002)(50986999)(76176999)(7846002)(305945005)(7696003)(76576001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB1686;H:BY2PR02MB1686.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2016 14:28:19.0979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1686 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7NESRB6023225 On 08/23/16 06:57, Bart Van Assche wrote: > On 08/22/16 11:32, Mikko Rapeli wrote: >> - * uint32_t (*get_region_size)(struct dm_dirty_log *log); >> + * __u32 (*get_region_size)(struct dm_dirty_log *log); > > uint32_t is a type that is defined by ANSI C but __u32 not. So this > change looks wrong to me. Would it have been sufficient to add "#include > " and keep the uint32_t etc. type names? Answering my own question: adding "#include " wouldn't be sufficient. How about adding the following code that also occurs in a few other uapi header files? #ifndef __KERNEL__ #include #endif #include Bart.