From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdFUWWD (ORCPT ); Wed, 21 Jun 2017 18:22:03 -0400 Received: from mail-dm3nam03on0117.outbound.protection.outlook.com ([104.47.41.117]:23494 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751884AbdFUWWB (ORCPT ); Wed, 21 Jun 2017 18:22:01 -0400 From: Haiyang Zhang To: Arnd Bergmann , Stephen Hemminger CC: KY Srinivasan , "David S. Miller" , Simon Xiao , "devel@linuxdriverproject.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] netvsc: don't access netdev->num_rx_queues directly Thread-Topic: [PATCH] netvsc: don't access netdev->num_rx_queues directly Thread-Index: AQHS6twrZnQK4G57Bkyx0uI2FYXtCqIv41wQ Date: Wed, 21 Jun 2017 22:21:57 +0000 Message-ID: References: <20170621221714.278724-1-arnd@arndb.de> In-Reply-To: <20170621221714.278724-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetBy=haiyangz@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-06-21T18:21:55.0818838-04:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [69.128.199.77] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR21MB0001;7:rr82+rPVkNugRWSDzFJVeV1yCeVV+XE9oDjdn8K5KHsA55V1WOwStVZqHkt9rwyrZWtejBvkw3C0SQaPemvevixeBkQ/h9cI8XY52Jg1Ogdjhc8mL+EU+Y7OqA6Woi87MtABUa0LU29btx25k4jOXBr56lZKkroQTfE8mPOe+7x3hG4LMr3nKhBt2ULlYok/D0l9+Kbb/O21wmx31iWP6Qu99e9511YAOxsQY00doftHrHOvRQfFJ22wWPMN0qChUFzPG49pex7gEZ4x5ST1siWSxqrqilxmCxskr/ConWvLTkIltk1p3u2eGJc1LG0XfHOYCkzwSeOF2MsVSM1tcB37SFs3oP5xmtQpTwWnS9I+qhn+Y02TDrWCgDsz9dmoK49KgG5EyMkuhwVn7Vmco9rVcsIqZ6gWrXamKlA4VMAI8UTX+tRliCWqHKZDAaQoYe2Sk1yus6lQU3hB04yogyFNNsqX9YBdjFdBTPGFtyeu6radbSSNgzHFDsKyyDz5rz/iBscQa3JOgsnoSobk1G6H0XKr+/5cODJM1TmdiNj3kuy4qzjXK90EN5SJ7TEXx6/jnB0LaDH3HaQOYeJysBJmjS4kFm67IJDojWhz28DafjqKZQplYWFtKEP43IVxgYY9ABrb35j9y90dD/TaSIQyvscQE/HXGximJBHFIllgwQw3MVBdoRje9LskDiKu3AsUr3iISzDbgKA2YRtgmz/hmU4quHIcwuUcDP2m4FUKGjk7zV+KhhYVe6D4VYYWPLBOIaB2oYeMQdB3aQu+jO0LldKpptmgC8RyVcVj3csMcmUKsM05zIFJ6Q58iWFW x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10019020)(6009001)(39400400002)(39850400002)(39410400002)(39860400002)(39450400003)(13464003)(377454003)(25786009)(305945005)(74316002)(5660300001)(66066001)(2906002)(8676002)(2950100002)(6636002)(54906002)(55016002)(189998001)(33656002)(2900100001)(9686003)(3660700001)(3280700002)(1511001)(2421001)(122556002)(478600001)(6506006)(6436002)(81166006)(2561002)(10090500001)(10290500003)(76176999)(53936002)(54356999)(86362001)(7736002)(8936002)(3846002)(6246003)(14454004)(6116002)(102836003)(7696004)(77096006)(50986999)(4326008)(38730400002)(53546010)(5005710100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR21MB0001;H:BY2PR21MB0004.namprd21.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: bb36a281-9aa6-4f6b-475d-08d4b8f3edeb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500055)(300135000095)(300000501055)(300135300095)(300000502055)(300135100095)(22001)(2017030254075)(300000503055)(300135400095)(48565401081)(201703131423075)(201703031133081)(300000504055)(300135200095)(300000505055)(300135600095)(300000506048)(300135500095);SRVR:BY2PR21MB0001; x-ms-traffictypediagnostic: BY2PR21MB0001: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR21MB0001;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR21MB0001; x-forefront-prvs: 0345CFD558 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2017 22:21:57.1453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR21MB0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5LMMIGe021493 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Wednesday, June 21, 2017 6:17 PM > To: Stephen Hemminger > Cc: Arnd Bergmann ; KY Srinivasan ; > Haiyang Zhang ; David S. Miller > ; Simon Xiao ; > devel@linuxdriverproject.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] netvsc: don't access netdev->num_rx_queues directly > > This structure member is hidden behind CONFIG_SYSFS, and we > get a build error when that is disabled: > > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels': > drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has > no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh': > drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has > no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > > As the value is only set once to the argument of alloc_netdev_mq(), > we can compare against that constant directly. > > Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") > Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of > channels") > Signed-off-by: Arnd Bergmann Reviewed-by: Haiyang Zhang Thanks.