From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A327C4CC624; Wed, 14 Oct 2026 10:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791973676; cv=fail; b=Pj1562KWnD50vaJ4R4lfDMti/xcy6VgL88jxMxPZg04vhlpcgbXvzAdDyp2Q7c191+9LkELz/jciS5Yzcb7PMCw4tAgC7UiQZ6JSHCqKyWYnUfqZ4H/MI0igDH5qtCFxgI8O5EOYSFrEeDpM7CZdnIuMa9iHVWgSQBnrURzB6OA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791973676; c=relaxed/simple; bh=7JxD/dU7Pf7fD76Re/OpDCxfwMrX596JgKDNSGTwaEs=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=YTfW4J/rWL1sSgMXQwta6AhgriBVdc1p+8l4zD6vRSBy/76swwrGrwLGjtFIgBcbodTmCZeQvdhI477XRcOQavu2oUtymYmpxh2RvDdJA6gDWzNCW5WWmDo0KjV4CVqoelnDkBt7QILD5ccH/7/cbGYOTEQxNOb+aSX/7UIh97U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=R5ijFxBj; arc=fail smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="R5ijFxBj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791973674; x=1823509674; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7JxD/dU7Pf7fD76Re/OpDCxfwMrX596JgKDNSGTwaEs=; b=R5ijFxBj8jPObYvHOHOQTgCbSFYt4bw+NhYlrWjX+SGtB+O/kvvfej6h 6QTsJZWOBdDP0aGG7++LDiCWtmsf4HrrfrOsglMJrPUPfgVlKHD1B1Xfs VvaDp8uausmLgFbK86frIOrInlMfhZzlaklnrs6+NZ+Y5zEsMmvW8Oj5S zGBS7ciDx00DNUE4/YPgcV7ZRGeItCsSi5e3vm4DLl4Ox9h/gB7relHcC 8a+97fRFGAczt0NqNiP1KzKiKVg8zDFYrM4KrXr0VLoJckdsoQGEyHnr1 vD9GZtYs8oa1WfrU1Gx4oKD9IxghJ+I7H8P55+IyXf4Q97pwSJZb0L16W g==; X-CSE-ConnectionGUID: Fwgl65RORTyAj5V4b1Zguw== X-CSE-MsgGUID: aJhz8T9TRuyGTf7hhlLj2w== X-IronPort-AV: E=McAfee;i="6800,10657,11934"; a="707851" X-IronPort-AV: E=Sophos;i="6.27,157,1787036400"; d="scan'208";a="707851" Received: from fmviesa012.fm.intel.com ([10.60.135.152]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2026 03:27:53 -0700 X-CSE-ConnectionGUID: 9q+ZR/6wQXWvEgOZkm3ztg== X-CSE-MsgGUID: APqclEyPSTW9r5QqNfbZVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,157,1787036400"; d="scan'208";a="3151127" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa012.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2026 03:27:53 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Wed, 14 Oct 2026 03:27:52 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49 via Frontend Transport; Wed, 14 Oct 2026 03:27:52 -0700 Received: from SN4PR0501CU005.outbound.protection.outlook.com (40.93.194.18) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Wed, 14 Oct 2026 03:27:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uWtu4ES76AtpkqO8jkT9a+kXNc5HkFVSpbAtFyngOYSc+dzsdvSbQ+9QFi3UWODFecopYCgKv7NDPMAiGCWiEry5lX+QVey1Zxwlqv4f19pZYgItlak6dbFtSQQm1O6q0dUqP2IC365edrfkqAdwqv1okP3j/9hI9c+OPadswegE0OxU5VYXHW/sN9TMz9YNcce+3Clv0eT6cbDTdTV5xFZiKNaeFh77ScEMpT2jlAkhLFUtfQHwVSXxhlBhF0hMrVzi0E9+Hv6CryBzmN3fDtBfzeX5DKqXjkOgxoCnhXCMQ7aqgoykqKrhSt2gzmLYFXrfJyCMNl+xuJl7fF0zbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X0xAcWVe9Xi7Fh35e6Cak0UMDeNR4bJk3nMSAE0Cw5M=; b=W18QAFrvVjKfGcHCheXPsWXDp/Xhj131HUMtsYmNZKieszsgzV7yXfeKphGVVR0Him1vwspfSriefqRteE5QadmWZWRxU4Ul/oiQe0zqUi57ELPrKpN8B3WVbh2jm2s+702pnLOvdEHL1+H9MwcXkdLJTivUYswKK5E3SG6qosbMIi0BxjHNJ+IxAI56FIFUK7Ti2I8maS2YVspc1I3dnlTkuG3+Sv9+q2XhUdeHV1vmJFXYVTR1LYapZblOIFUq2hy4KN3odyjBTV0VpQ4T8qDtQB8ERS7SDMH+gyXyOEWOf0uERzXi6Xurg69hPpP4IsdwMJCcpVAjE1MmP8EWBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3976.namprd11.prod.outlook.com (2603:10b6:a03:187::14) by DM3PPF17031675B.namprd11.prod.outlook.com (2603:10b6:f:fc00::f09) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Wed, 14 Oct 2026 10:27:49 +0000 Received: from BY5PR11MB3976.namprd11.prod.outlook.com ([fe80::c23a:c952:eb75:d4d4]) by BY5PR11MB3976.namprd11.prod.outlook.com ([fe80::c23a:c952:eb75:d4d4%4]) with mapi id 15.21.0522.012; Wed, 14 Oct 2026 10:27:48 +0000 From: "Singh, Ayush1X" To: Aaron Ma , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Henry Tieman , "moderated list:INTEL ETHERNET DRIVERS" Subject: RE: [PATCH v2 2/2] ice: clear Flow Director entries before reset cleanup Thread-Topic: [PATCH v2 2/2] ice: clear Flow Director entries before reset cleanup Thread-Index: AQHdPr98uBGBLMl3vEStvD0C6k9imLb80LkA Date: Wed, 14 Oct 2026 10:27:48 +0000 Message-ID: References: <20260907115221.926007-1-aaron.ma@canonical.com> <20260907115221.926007-2-aaron.ma@canonical.com> In-Reply-To: <20260907115221.926007-2-aaron.ma@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB3976:EE_|DM3PPF17031675B:EE_ x-ms-office365-filtering-correlation-id: 0b5e8cfc-da7c-477b-b073-08df29ddcb63 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|23010399003|11063799006|4143699003|38070700021|921020|56012099006|18002099003|22082099003|261009223027099003|10067099003; x-microsoft-antispam-message-info: HJOXKbUFojYNpm2NNd2bUPJRGSfVe2JA/XD/AsMK3eBfVebMq5eEw8LU5NQ4/1NUt2f7cuW+Z5EuDwceOCq+cKvxIJqwj+JWPM1zcF7X49gfuZ1TVeepwcFhOFx+jnhjJ7TwHaf39Op3CMNw1bKiLpInKmiQTWzNq+jA8qKO8NCFeg5ni/862EjppYBWkWjqXvq9pmMIKOB4bfxNePmQrvyxdl0xYz2+CJqzH6vsuFghE8/wUv8objPPrTLnLFhY3EFqRStOs8YSFK1R+tghEWeypCC8ED1VizEfwRa2JscqkjbD3JjgjeG+xjBKwdETDUlrHUxA5bHG6uE31u1rrC7wkJ7BdOU3CZT28LPLDsd57+br5dtcgOQXjumeIld1VOugnQ8DizB9iqBIW6oTm1dWN+1H0rnOw7lxeTr8/HUHUQI1RgKcZa/Q0UY7zFjn026F49L9wHGzFF3GicWtopnyU8enNr98T0sbkJdrOmdACCjX1yRffsh1WwjbA/b7j48mlVyE6kmQ/MIaQ39m1nxJVoK6S03nHIWBD6CHQ+hUkxZiBxeSfLfXVGpkpi+a8Z5MbY1MSYLxWskcM+R++3eb1N+7JzSaZOwifSaRjA+xyFeW2n91rIaQXrXvx6XiW1BQTGzcqwx1QvJvdD/htseOXY41HtwUEOYXN2zbVKFtb8MVbnQSNdiJqRmFXL6V/KdNMhCEoIzBTDrRflvA//Q3fcCQGJtNx7hf4lyiiItBySiiDvg9+k6gzzOGadWq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB3976.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(11063799006)(4143699003)(38070700021)(921020)(56012099006)(18002099003)(22082099003)(261009223027099003)(10067099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U2Jn4O8sREK2FTCvDA88sdOzDVilpQ4yN1X/sExH+wFFAAVwYtWfsUcMsqvD?= =?us-ascii?Q?998bOfF1xOWVKjUI0XzkF88+taLQe2EBISfZvSxk1rpkfo3LBxDrXNHnqmPo?= =?us-ascii?Q?1ycIEAsJXlJa4XGmcLHFnn9W+GMbwm2jdclUhupHIYMhesPTkERhjYW88ANZ?= =?us-ascii?Q?HlbA1HjKSqhL0Z2OaVqXrEPH8jZDw9+aFceQ88/AWVmJl41Jm/K5HgULPWKC?= =?us-ascii?Q?EJ2jSeC9HHbfPQnH29w74XajWLvskOiF4K+IobyyF9diIuHVQ9TD0tuAhbko?= =?us-ascii?Q?B5wag9CUc0A8/h5kSMNgNsxcsm8Zq5Riy74p28bBs1bE8ySCKzn+9pn1Z3gh?= =?us-ascii?Q?ar5m7hVmDd9yOKdoXTyRDZJZGoLe1GdoXKhe2xMd5JVvsoghAPi8JCGeJIE9?= =?us-ascii?Q?L9MwTK8JO2mlKuBJ+EkKK1a9F0AMe7Ec76UQxmmt+b9eT4zLOcTwikj6RM+c?= =?us-ascii?Q?TVV6itCX2zam8cQSmrwf+JoJo60eRPpA7Vh8JcmXUVBknDq/hVeqNbpZsCjp?= =?us-ascii?Q?ANjbh7l8UUup7wSATMoDWt/LJ18FV82Je3UUe8gOWzxdR400srnQ8k3gxigC?= =?us-ascii?Q?f4z5SlRahwfj16B8rAm1SbpFjR2Ij0znJNvJKnGM0hCihoo6zc11hejYew2T?= =?us-ascii?Q?JOqcGsbGM7Ktky86ouajD0CkcI1NmAA9vT2mscd4cMulBKSJMl7NKxOfkJbU?= =?us-ascii?Q?9NRpkIfn0VttLkaGKrAn/agJxkUDxIulmL/0PeH4M3j92iWN+PCts5mMqk75?= =?us-ascii?Q?t/ZVSL0yVMcMSACNEWx6kSchbwBT11AzWevVDUVbEQTvy8Mv3vmVG5E3BDQm?= =?us-ascii?Q?AIHqb7VfKo2BjfntNxqMexXUi2p9dFfzjUF8EDsnmOTm+EL89GAwKxyn45un?= =?us-ascii?Q?J4NcGFzq2wnie0wGQ7UMYCqaf9QWUMo4cuHzg3HfC0TK486QMl8EhftUAof3?= =?us-ascii?Q?+1ISql3CffHN2VMr9t/uT5x0vABUFher2mA2bySlvepB+XNsIaDff/3CIKtf?= =?us-ascii?Q?dkFhIPbZ/LWRv1eYsdlF9tGVBnZNjMjWRMeHR6UHVMP96g9VFyTCk5I1sZ5x?= =?us-ascii?Q?xH7QQI08oDwTZ38oochZyQM58zKLCB21As30nUd8WHZy23Y4hSX37m3syIjM?= =?us-ascii?Q?+xkqqmxr8vflYANjdiV6mwEWUwIu8+n+A6WVW1qjyAbPnQC8r9JcwYVdLZyQ?= =?us-ascii?Q?hq2IZjXcbhA60P0mVUoAQm6l+nv7p5oSsV4Rmd7NZsDvdnUvr0xE8SmWbID3?= =?us-ascii?Q?PG6+SzFJZJ6dft87ZGuyvY1cfJon+QJ0KMpatiFsz6bP24Xk/7NXtxjhVz4x?= =?us-ascii?Q?TO/rAo2/TLRgEgTqaWlC3FAbxNAKc+Pec32joKmiSmOKV+rJ56Mnk2cs9a3V?= =?us-ascii?Q?J3UmqYCmBk1pSfkYIMbL0yDatRjqXxPNwNJCenm2muzWa0fT3Nypw64AFDCn?= =?us-ascii?Q?L08L0PGRjyMBQPmvZtK1VDMwQuzieq7btEC3lUrO2+gkBA4f1zdYQwSA6yYP?= =?us-ascii?Q?DNX6qnKQmz1pBU+9lA67x8TEIVJkC1Be4SGjRdOkAb2K64BsrDruyc2EWc2E?= =?us-ascii?Q?tnl/kz+UVnK4l6rtmsBr5AqfUlENG7t/472mc3ILOpM3W7PhFm30NaHSBp1X?= =?us-ascii?Q?WsJGmMhfzIMuyLG/l78wYbLD659MmoSNPt8zIOj2zMe9HlWg/pLgJprHhvjg?= =?us-ascii?Q?MeyykJJ5CYfLEhl26UKooE9HvvX5ImPhFHhuj08LaJEXpTXVWhNqFWCGnVla?= =?us-ascii?Q?EACOhcL/Fw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: QHxb8OQleqMW0L1+2s4fNMFpScIY0hlRQu2p9V7m16gXtDpALJY3jb6fdK1ve2D2U7sUGPc0Ob6PVU9ifUTvfl8HUeBBSrG7LrU2R0LN59EmaHlHL2CFYtNvLONt2r5jGgCShzlrRAsJK8dSxpJn6d5hnrxPAkNFQQhQvFQNsIzVVwlO30cfT9dUKyQnd6GkPyderLYDL323hX/g5CLyu62lJct17CM/PJmSBUd1L9AjXoz5mYZyAcN1nU+XhLK0m576SIwnYWRr5viz+BWkMzV4bR4JfWPH9XU0M5uOULCXiIceKKDYmwuvpMaEJ49tDJKME7XnUXKuW5maGjwd8A== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3976.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b5e8cfc-da7c-477b-b073-08df29ddcb63 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2026 10:27:48.5954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aL1Eewbi1zusFlpd6yfXowiqz3yGqHdiTbljJqgEyy3QFv1n83Htnri3/d5aPsA8EhuRrr95qwm3S8VoKshlZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF17031675B X-OriginatorOrg: intel.com > -----Original Message----- > From: Aaron Ma =20 > Sent: 07 September 2026 17:22 > To: Nguyen, Anthony L ; Kitszel, Przemyslaw <= przemyslaw.kitszel@intel.com>; Andrew Lunn ; David S= . Miller ; Eric Dumazet ; Jakub K= icinski ; Paolo Abeni ; netdev@vger.ker= nel.org; linux-kernel@vger.kernel.org > Cc: Henry Tieman ; moderated list:INTEL ETHERNE= T DRIVERS > Subject: [PATCH v2 2/2] ice: clear Flow Director entries before reset cle= anup > > Flow Director profiles retain handles to generic flow entries. Reset call= s > ice_clear_hw_tbls() to free those entries, but leaves the Flow Director h= andles unchanged until replay replaces them. > > If rebuild fails before replay completes, later driver removal follows a = stale handle and dereferences a freed flow entry in ice_flow_rem_entry(). KASAN reports a wild access to list poison from ice_fdir_erase_flow_from_hw= (). > > The failure is reported as: > > KASAN: maybe wild-memory-access in range [0xdead000000000108-...] > RIP: ice_flow_rem_entry+0xaf/0x170 [ice] > ice_fdir_erase_flow_from_hw+0x1ee/0x420 [ice] > > Clear the Flow Director handles while holding hw->fdir_fltr_lock before t= he hardware tables free their entries. A successful replay installs new han= dles, while a failed rebuild leaves them invalid for later cleanup. > > Fixes: 148beb612031 ("ice: Initialize Flow Director resources") > Reviewed-by: Przemek Kitszel > Signed-off-by: Aaron Ma > --- > v1 -> v2: > - Acquire hw->fdir_fltr_lock in ice_fdir_clear_flow_handles() to > synchronize with concurrent ethtool filter add/del. > > drivers/net/ethernet/intel/ice/ice.h | 1 + > .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 26 +++++++++++++++++++ > drivers/net/ethernet/intel/ice/ice_main.c | 2 ++ > 3 files changed, 29 insertions(+) > Tested-by: Ayush Singh < ayush1x.singh@intel.com > (A Contingent worker at = Intel)