From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Simek, Michal" <michal.simek@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"Buddhabhatti, Jay" <jay.buddhabhatti@amd.com>,
"Kundanala, Praveen Teja" <praveen.teja.kundanala@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"saikrishna12468@gmail.com" <saikrishna12468@gmail.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
Date: Thu, 8 Aug 2024 05:53:42 +0000 [thread overview]
Message-ID: <BY5PR12MB42586B02EB54BA76704F1062DBB92@BY5PR12MB4258.namprd12.prod.outlook.com> (raw)
In-Reply-To: <27da3261-8c1e-4c4d-a548-acdfee1909f2@linaro.org>
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Monday, August 5, 2024 3:38 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij
> <linus.walleij@linaro.org>; Simek, Michal <michal.simek@amd.com>; Rob
> Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Buddhabhatti, Jay <jay.buddhabhatti@amd.com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@amd.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-gpio@vger.kernel.org; devicetree@vger.kernel.org;
> saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
> platform
>
> On 01/08/2024 14:00, Sai Krishna Potthuri wrote:
> > Add Xilinx Versal compatible string and corresponding groups, function
> > and pins properties to support pin controller features on Versal platform.
> >
> > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> > ---
> > .../bindings/pinctrl/xlnx,versal-pinctrl.yaml | 398
> > ++++++++++++++++++
> > 1 file changed, 398 insertions(+)
> > + bias-pull-up: true
> > +
> > + bias-pull-down: true
> > +
> > + bias-disable: true
> > +
> > + input-schmitt-enable: true
> > +
> > + input-schmitt-disable: true
> > +
> > + bias-high-impedance: true
> > +
> > + low-power-enable: true
> > +
> > + low-power-disable: true
>
> Why do you need to copy all of these? Just switch to unevaluatedProperties.
I tried with "unevaluatedProperties: false", it worked but by adding this all the
properties in the pincfg-node.yaml become valid for this platform which is not
true. Not all the properties in the pincfg-node.yaml are supported in this platform.
So, is there any other way of representing this?
Regards
Sai Krishna
next prev parent reply other threads:[~2024-08-08 5:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:00 [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform support Sai Krishna Potthuri
2024-08-01 12:00 ` [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform Sai Krishna Potthuri
2024-08-05 10:07 ` Krzysztof Kozlowski
2024-08-07 5:48 ` Potthuri, Sai Krishna
2024-08-08 5:53 ` Potthuri, Sai Krishna [this message]
2024-08-10 13:35 ` Krzysztof Kozlowski
2024-08-13 5:40 ` Potthuri, Sai Krishna
2024-08-13 10:14 ` Krzysztof Kozlowski
2024-08-13 16:01 ` Potthuri, Sai Krishna
2024-08-01 12:00 ` [PATCH v3 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID Sai Krishna Potthuri
2024-08-01 12:00 ` [PATCH v3 3/3] pinctrl: pinctrl-zynqmp: Add support for Versal platform Sai Krishna Potthuri
2024-08-04 14:49 ` [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform support Krzysztof Kozlowski
2024-08-05 8:58 ` Potthuri, Sai Krishna
2024-08-05 10:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB42586B02EB54BA76704F1062DBB92@BY5PR12MB4258.namprd12.prod.outlook.com \
--to=sai.krishna.potthuri@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jay.buddhabhatti@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=praveen.teja.kundanala@amd.com \
--cc=robh+dt@kernel.org \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®