From: Pawel Laszczak <pawell@cadence.com>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"balbi@kernel.org" <balbi@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
lkml <linux-kernel@vger.kernel.org>,
Alan Douglas <adouglas@cadence.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Sun, 16 Dec 2018 13:01:36 +0000 [thread overview]
Message-ID: <BYAPR07MB4709A216316119DCFF25A31EDDA30@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <CAL411-phi=PV1Voe=mTrjKDXNPL7dt9B-f_RaekCoXy=pqNMPA@mail.gmail.com>
Hi Peter
>On Mon, Dec 10, 2018 at 8:55 PM Pawel Laszczak <pawell@cadence.com> wrote:
>>
>> This patch introduce new Cadence USBSS DRD driver
>> to linux kernel.
>>
>> The Cadence USBSS DRD Driver is a highly
>> configurable IP Core which can be
>> instantiated as Dual-Role Device (DRD),
>> Peripheral Only and Host Only (XHCI)
>> configurations.
>>
>> The current driver has been validated with
>> FPGA burned. We have support for PCIe
>> bus, which is used on FPGA prototyping.
>>
>> The host side of USBSS-DRD controller is compliance
>> with XHCI specification, so it works with
>> standard XHCI linux driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>
>I have compiled it at my ARM64 platform, and will give you more feedback after
>adding platform support. Below is one compile warning, please fix
>
> CC drivers/usb/cdns3/host.o
> AR drivers/usb/cdns3/cdns3-pci.o
>/home/b29397/work/projects/linux-imx/drivers/usb/cdns3/gadget.c: In
>function ‘cdns3_gadget_ep_disable’:
>/home/b29397/work/projects/linux-imx/drivers/usb/cdns3/gadget.c:1122:19:
>warning: ‘priv_dev’ may be used uninitialized in this function
>[-Wmaybe-uninitialized]
> dev_dbg(priv_dev->dev, "usbss: invalid parameters\n");
> ^~
> AR drivers/usb/cdns3/cdns3.o
>
I found this also. Some time ago I changed
pr_err("usbss: invalid parameters\n");
to
dev_err(priv_dev->dev, "usbss: invalid parameters\n");
In cdns3_gadget_ep_disable function and it was mistake.
I don't know why I didn't see this warning before posting patch.
Cheers
Pawel
next prev parent reply other threads:[~2018-12-16 13:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-11 10:16 ` Roger Quadros
2018-12-13 9:20 ` Peter Chen
2018-12-13 9:25 ` Pawel Laszczak
2018-12-20 20:01 ` Rob Herring
2018-12-22 22:24 ` Pawel Laszczak
2018-12-27 21:01 ` Rob Herring
2018-12-31 5:35 ` Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-11 9:39 ` Roger Quadros
2018-12-11 10:01 ` Pawel Laszczak
2018-12-11 12:15 ` Felipe Balbi
2018-12-11 11:46 ` Felipe Balbi
2018-12-11 12:14 ` Felipe Balbi
2018-12-11 19:04 ` Pawel Laszczak
2018-12-12 2:04 ` Peter Chen
2018-12-12 6:55 ` Felipe Balbi
2018-12-12 7:38 ` Peter Chen
2018-12-12 8:34 ` Felipe Balbi
2018-12-12 9:24 ` Peter Chen
2018-12-12 15:53 ` Bin Liu
2018-12-13 1:21 ` Peter Chen
2018-12-12 6:52 ` Felipe Balbi
2018-12-14 3:46 ` Kishon Vijay Abraham I
2018-12-17 5:46 ` Pawel Laszczak
2018-12-17 11:25 ` Pawel Laszczak
2018-12-17 11:34 ` Felipe Balbi
2018-12-17 11:51 ` Pawel Laszczak
2018-12-17 11:56 ` Felipe Balbi
2018-12-13 9:35 ` Peter Chen
2018-12-16 13:01 ` Pawel Laszczak [this message]
2018-12-14 22:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB4709A216316119DCFF25A31EDDA30@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hzpeterchen@gmail.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®