mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tristram.Ha@microchip.com>
To: <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
	<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
	<f.fainelli@gmail.com>, <UNGLinuxDriver@microchip.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs
Date: Tue, 25 Jul 2023 23:51:43 +0000	[thread overview]
Message-ID: <BYAPR11MB3558593293C41090D57EADE4EC03A@BYAPR11MB3558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230724164351.2ecf6faf@kernel.org>

> On Thu, 20 Jul 2023 17:40:53 -0700 Tristram.Ha@microchip.com wrote:
> > +#include <linux/inetdevice.h>
> > +#include <net/addrconf.h>
> > +#include <net/if_inet6.h>
> > +#include <net/ipv6.h>
> 
> You don't need these includes any more, right?
> 
> >  #include <linux/smscphy.h>
> >
> >  /* Vendor-specific PHY Definitions */
> 
> > +static int lan874x_set_wol(struct phy_device *phydev,
> > +                        struct ethtool_wolinfo *wol)
> > +{
> > +     struct net_device *ndev = phydev->attached_dev;
> > +     struct smsc_phy_priv *priv = phydev->priv;
> > +     u16 val, val_wucsr;
> > +     u8 data[128];
> > +     u8 datalen;
> > +     int rc;
> > +
> > +     if (wol->wolopts & WAKE_PHY)
> > +             return -EOPNOTSUPP;
> 
> You're not advertising the support for WAKE_PHY, so you don't have to
> check if it was requested. See recent commit 55b24334c0f2.

They will be removed in next update.


      reply	other threads:[~2023-07-25 23:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  0:40 Tristram.Ha
2023-07-24 11:50 ` Simon Horman
2023-07-24 15:35 ` Florian Fainelli
2023-07-24 23:43 ` Jakub Kicinski
2023-07-25 23:51   ` Tristram.Ha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3558593293C41090D57EADE4EC03A@BYAPR11MB3558.namprd11.prod.outlook.com \
    --to=tristram.ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®