mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tristram.Ha@microchip.com>
To: <pabeni@redhat.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>
Subject: RE: [PATCH net] net: phy: Micrel KSZ8061: fix errata solution not taking effect problem
Date: Thu, 30 May 2024 22:42:23 +0000	[thread overview]
Message-ID: <BYAPR11MB35587571DADF73195961A9DFECF32@BYAPR11MB3558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b52073452a085524b436762aeb3aff8feb8005d1.camel@redhat.com>

> Subject: Re: [PATCH net] net: phy: Micrel KSZ8061: fix errata solution not taking effect
> problem
> 
> On Tue, 2024-05-28 at 14:37 -0700, Tristram.Ha@microchip.com wrote:
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > KSZ8061 needs to write to a MMD register at driver initialization to fix
> > an errata.  This worked in 4.14 kernel but not in newer kernels.  The
> > issue is the main phylib code no longer resets PHY at the very beginning.
> > Calling phy resuming code later will reset the chip if it is already
> > powered down at the beginning.  This wipes out the MMD register write.
> > Solution is to implement a phy resume function for KSZ8061 to take care
> > of this problem.
> >
> > Fixes: 232ba3a51cc2 ("net: phy: Micrel KSZ8061: link failure after cable connect")
> 
> As the blamed commit belongs to 5.0 and the changelog hints anything
> after 4.14 is broken, it looks like there is an inconsistency. Please
> fix the changelog or the tag.

A customer reported this problem and said they were using 4.14 and cited
this commit, so I assumed it was added in that kernel.  Indeed 4.19
kernel has this code, so it was probably backported.

I will update the comment.


      reply	other threads:[~2024-05-30 22:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 21:37 Tristram.Ha
2024-05-30  9:21 ` Paolo Abeni
2024-05-30 22:42   ` Tristram.Ha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB35587571DADF73195961A9DFECF32@BYAPR11MB3558.namprd11.prod.outlook.com \
    --to=tristram.ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®