From: George Song <George.Song@maximintegrated.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"george.song@analog.com" <george.song@analog.com>,
Ryan Lee <RyanS.Lee@maximintegrated.com>,
Steve Lee <SteveS.Lee@maximintegrated.com>
Subject: RE: [EXTERNAL] Re: [v3 2/2] ASoC: max98520: add max98520 audio amplifier driver
Date: Wed, 20 Oct 2021 05:06:17 +0000 [thread overview]
Message-ID: <BYAPR11MB367197EB4E103B53DBBAC6D0F4BE9@BYAPR11MB3671.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YW6zKsiWPE+xGWTy@sirena.org.uk>
> On Tue, Oct 19, 2021 at 07:57:26AM +0000, George Song wrote:
>
> > > > + /* L/R mix configuration */
> > > > + regmap_write(max98520->regmap,
> MAX98520_R2043_PCM_RX_SRC1, 0x2);
> > > > +
> > > > + regmap_write(max98520->regmap,
> MAX98520_R2044_PCM_RX_SRC2,
> > > > +0x10);
> > >
> > > These should be exposed to the user, not hard coded - different
> > > systems may need different configurations.
> > It`s already exposed for 2043 register which is regarding mono
> mixer for "DAI Sel Mux"
> > It will be exposed for 2044 register which is regarding pcm input
> channel selection to dapm mixer.
>
> Then leave the values at the defaults and let the user select what's
> sensible for their system.
It will be left the default value in probe function and
described mixer/widget comment
>
> Please fix your mail client to word wrap within paragraphs at
> something substantially less than 80 columns. Doing this makes your
> messages much easier to read and reply to.
OK I see.
next prev parent reply other threads:[~2021-10-20 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:35 [v3 1/2] ASoC: dt-bindings: max98520: add initial bindings George Song
2021-10-18 8:35 ` [v3 2/2] ASoC: max98520: add max98520 audio amplifier driver George Song
2021-10-18 12:38 ` Mark Brown
2021-10-19 7:57 ` [EXTERNAL] " George Song
2021-10-19 11:59 ` Mark Brown
2021-10-20 5:06 ` George Song [this message]
2021-10-18 19:49 ` [v3 1/2] ASoC: dt-bindings: max98520: add initial bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB367197EB4E103B53DBBAC6D0F4BE9@BYAPR11MB3671.namprd11.prod.outlook.com \
--to=george.song@maximintegrated.com \
--cc=RyanS.Lee@maximintegrated.com \
--cc=SteveS.Lee@maximintegrated.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.song@analog.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®