From: "Bird, Tim" <Tim.Bird@sony.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"shuah@kernel.org" <shuah@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>
Cc: "joe@perches.com" <joe@perches.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-spdx@vger.kernel.org" <linux-spdx@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Goldwyn Rodrigues <rgoldwyn@suse.com>, Kuno Woudt <kuno@frob.nl>,
Richard Fontana <fontana@sharpeleven.org>,
"copyleft-next@lists.fedorahosted.org"
<copyleft-next@lists.fedorahosted.org>,
Ciaran Farrell <Ciaran.Farrell@suse.com>,
Christopher De Nicolo <Christopher.DeNicolo@suse.com>,
Christoph Hellwig <hch@lst.de>, Jonathan Corbet <corbet@lwn.net>,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: RE: [PATCH v11 2/2] testing: use the copyleft-next-0.3.1 SPDX tag
Date: Mon, 3 Oct 2022 18:42:59 +0000 [thread overview]
Message-ID: <BYAPR13MB2503DA96FB9E4F0ABF62B795FD5B9@BYAPR13MB2503.namprd13.prod.outlook.com> (raw)
In-Reply-To: <20221003165849.1658170-3-mcgrof@kernel.org>
> -----Original Message-----
> From: Luis Chamberlain <mcgrof@infradead.org> On Behalf Of Luis Chamberlain
> Subject: [PATCH v11 2/2] testing: use the copyleft-next-0.3.1 SPDX tag
>
> Two selftests drivers exist under the copyleft-next license.
> These drivers were added prior to SPDX practice taking full swing
> in the kernel. Now that we have an SPDX tag for copyleft-next-0.3.1
> documented, embrace it and remove the boiler plate.
>
> Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
> Cc: Kuno Woudt <kuno@frob.nl>
> Cc: Richard Fontana <fontana@sharpeleven.org>
> Cc: copyleft-next@lists.fedorahosted.org
> Cc: Ciaran Farrell <Ciaran.Farrell@suse.com>
> Cc: Christopher De Nicolo <Christopher.DeNicolo@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Thorsten Leemhuis <linux@leemhuis.info>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> lib/test_kmod.c | 12 +-----------
> lib/test_sysctl.c | 12 +-----------
> tools/testing/selftests/kmod/kmod.sh | 13 +------------
> tools/testing/selftests/sysctl/sysctl.sh | 12 +-----------
> 4 files changed, 4 insertions(+), 45 deletions(-)
>
> diff --git a/lib/test_kmod.c b/lib/test_kmod.c
> index cb800b1d0d99..6423df9fa8dd 100644
> --- a/lib/test_kmod.c
> +++ b/lib/test_kmod.c
> @@ -1,18 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR copyleft-next-0.3.1
> /*
> * kmod stress test driver
> *
> * Copyright (C) 2017 Luis R. Rodriguez <mcgrof@kernel.org>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the Free
> - * Software Foundation; either version 2 of the License, or at your option any
> - * later version; or, when distributed separately from the Linux kernel or
> - * when incorporated into other software packages, subject to the following
> - * license:
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of copyleft-next (version 0.3.1 or later) as published
> - * at http://copyleft-next.org/.
> */
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> diff --git a/lib/test_sysctl.c b/lib/test_sysctl.c
> index 9a564971f539..e2a816d85ea2 100644
> --- a/lib/test_sysctl.c
> +++ b/lib/test_sysctl.c
> @@ -1,18 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR copyleft-next-0.3.1
> /*
> * proc sysctl test driver
> *
> * Copyright (C) 2017 Luis R. Rodriguez <mcgrof@kernel.org>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the Free
> - * Software Foundation; either version 2 of the License, or at your option any
> - * later version; or, when distributed separately from the Linux kernel or
> - * when incorporated into other software packages, subject to the following
> - * license:
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of copyleft-next (version 0.3.1 or later) as published
> - * at http://copyleft-next.org/.
> */
>
> /*
> diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh
> index afd42387e8b2..7189715d7960 100755
> --- a/tools/testing/selftests/kmod/kmod.sh
> +++ b/tools/testing/selftests/kmod/kmod.sh
> @@ -1,18 +1,7 @@
> #!/bin/bash
> -#
> +# SPDX-License-Identifier: GPL-2.0-or-later OR copyleft-next-0.3.1
> # Copyright (C) 2017 Luis R. Rodriguez <mcgrof@kernel.org>
> #
> -# This program is free software; you can redistribute it and/or modify it
> -# under the terms of the GNU General Public License as published by the Free
> -# Software Foundation; either version 2 of the License, or at your option any
> -# later version; or, when distributed separately from the Linux kernel or
> -# when incorporated into other software packages, subject to the following
> -# license:
> -#
> -# This program is free software; you can redistribute it and/or modify it
> -# under the terms of copyleft-next (version 0.3.1 or later) as published
> -# at http://copyleft-next.org/.
> -
> # This is a stress test script for kmod, the kernel module loader. It uses
> # test_kmod which exposes a series of knobs for the API for us so we can
> # tweak each test in userspace rather than in kernelspace.
> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
> index f50778a3d744..bfc54b422f25 100755
> --- a/tools/testing/selftests/sysctl/sysctl.sh
> +++ b/tools/testing/selftests/sysctl/sysctl.sh
> @@ -1,16 +1,6 @@
> #!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0-or-later OR copyleft-next-0.3.1
> # Copyright (C) 2017 Luis R. Rodriguez <mcgrof@kernel.org>
> -#
> -# This program is free software; you can redistribute it and/or modify it
> -# under the terms of the GNU General Public License as published by the Free
> -# Software Foundation; either version 2 of the License, or at your option any
> -# later version; or, when distributed separately from the Linux kernel or
> -# when incorporated into other software packages, subject to the following
> -# license:
> -#
> -# This program is free software; you can redistribute it and/or modify it
> -# under the terms of copyleft-next (version 0.3.1 or later) as published
> -# at http://copyleft-next.org/.
>
> # This performs a series tests against the proc sysctl interface.
>
> --
> 2.35.1
Luis,
I think you know that I'm not a fan of copyleft-next. However, having
said that, this conversion from boilerplate text to SPDX identifier line is very
welcome. Thanks for this change.
Reviewed-by: Tim Bird <tim.bird@sony.com>
-- Tim
next prev parent reply other threads:[~2022-10-03 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 16:58 [PATCH v11 0/2] SPDX: add copyleft-next-0.3.1 Luis Chamberlain
2022-10-03 16:58 ` [PATCH v11 1/2] LICENSES: Add the copyleft-next-0.3.1 license Luis Chamberlain
2022-10-03 18:47 ` Bird, Tim
2022-10-03 16:58 ` [PATCH v11 2/2] testing: use the copyleft-next-0.3.1 SPDX tag Luis Chamberlain
2022-10-03 18:42 ` Bird, Tim [this message]
2022-10-19 13:26 ` [PATCH v11 0/2] SPDX: add copyleft-next-0.3.1 Luis Chamberlain
2022-10-19 15:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR13MB2503DA96FB9E4F0ABF62B795FD5B9@BYAPR13MB2503.namprd13.prod.outlook.com \
--to=tim.bird@sony.com \
--cc=Christopher.DeNicolo@suse.com \
--cc=Ciaran.Farrell@suse.com \
--cc=akpm@linux-foundation.org \
--cc=copyleft-next@lists.fedorahosted.org \
--cc=corbet@lwn.net \
--cc=fontana@sharpeleven.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kuno@frob.nl \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mcgrof@kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®