mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: George Cherian <gcherian@marvell.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	George Cherian <gcherian@marvell.com>
Subject: Re: [PATCH] PCI: Add ACS quirk for Cavium multi-function devices
Date: Wed, 11 Aug 2021 04:10:51 +0000	[thread overview]
Message-ID: <BYAPR18MB267988A59552755801CBCBABC5F89@BYAPR18MB2679.namprd18.prod.outlook.com> (raw)


Hi Bjorn,

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Tuesday, August 10, 2021 8:18 PM
> To: George Cherian <gcherian@marvell.com>
> Cc: linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org;
> bhelgaas@google.com
> Subject: Re: [PATCH] PCI: Add ACS quirk for Cavium multi-function
> devices
> 
> On Tue, Aug 10, 2021 at 05:54:25PM +0530, George Cherian wrote:
> > Some Cavium endpoints are implemented as multi-function devices
> > without ACS capability, but they actually don't support peer-to-peer
> > transactions.
> >
> > Add ACS quirks to declare DMA isolation.
> >
> > Apply te quirk for following devices
> > 1. BGX device found on Octeon-TX (8xxx) 2. CGX device found on
> > Octeon-TX2 (9xxx) 3. RPM device found on Octeon-TX3 (10xxx)
> >
> > Signed-off-by: George Cherian <george.cherian@marvell.com>
> > ---
> >  drivers/pci/quirks.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index
> > 6d74386eadc2..076932018494 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -4840,6 +4840,10 @@ static const struct pci_dev_acs_enabled {
> >  	{ 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R
> */
> >  	/* Cavium ThunderX */
> >  	{ PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs },
> > +	/* Cavium multi-function devices */
> > +	{ PCI_VENDOR_ID_CAVIUM, 0xA026, pci_quirk_mf_endpoint_acs },
> > +	{ PCI_VENDOR_ID_CAVIUM, 0xA059, pci_quirk_mf_endpoint_acs },
> > +	{ PCI_VENDOR_ID_CAVIUM, 0xA060, pci_quirk_mf_endpoint_acs },
> 
> Is there a plan to add ACS capabilities to future devices, or is Cavium just
> resigned to forever adding and backporting quirks?

Yes, the plan is to get these fixed in future silicons. So that we won't be 
needing any quirks.

> 
> >  	/* APM X-Gene */
> >  	{ PCI_VENDOR_ID_AMCC, 0xE004, pci_quirk_xgene_acs },
> >  	/* Ampere Computing */
> > --
> > 2.25.1
> >

Regards,
-George

             reply	other threads:[~2021-08-11  4:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  4:10 George Cherian [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-10 12:24 George Cherian
2021-08-10 14:47 ` Bjorn Helgaas
2021-08-20 21:14 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB267988A59552755801CBCBABC5F89@BYAPR18MB2679.namprd18.prod.outlook.com \
    --to=gcherian@marvell.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®