From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B61245012 for ; Tue, 24 Feb 2026 05:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771910953; cv=none; b=nIZ+E8u84KznbkM6w2Zi2j0/H3ZcegSbo1K52ioyJ0G5sDP5R08w7KKwTBJVtyJjW4RdduVC5C/9A8zLinsRHgOtS2Vnuj0eVHnHv6dIhmbGeSnR6MF+mSzNCpoCdnL8CV4WqSvGDOVGzjILYslnATtaVyu4i5FjeoOfLFxWGFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771910953; c=relaxed/simple; bh=ZPzbL6OigHP2FtY4Vmwx8iRCZ2HHrPzRv4eo0lE0vL0=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=ITTD8joa9LCdi70HjaAQhsCtbYK2XVBGbVGk/AK98v4Hgyc8H3cY5C5/yawQzqNf0Ui/X+6Jwhavtn7ShX8MLi9S2Z+Cx4pd/4PA+/bd7RGruJW947zOlwVubkvG7sFgRuBjwO/BabiJCbRVdjlwf3oOJhhb4GzuuG6lMRwrOBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HyFA+fBh; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HyFA+fBh" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2baab3137bcso4276898eec.0 for ; Mon, 23 Feb 2026 21:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771910950; x=1772515750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=mZEchtNVjuRATqjtl+Wbd2xxGRNm9flPdO2/cfrPLzQ=; b=HyFA+fBhTpgPtZPxyZojOHpcIOI4Yqsec3rqg7NlplCiqbLzJV2scy7EgaePSHOPgt gT8ZRauZofU+AghWStFlnz0Bq9O/G3bR6egcD+76J/go+/kmojlYbZNSlXvf0rlKl2dQ Irjox1vx7uiqgWhb4rhVSy7oqws+/dOXok/WKvuHVzqzqTJOcaiJqFkQb1RI/kQ5VgAd oT4SkqylzGuRmnYb4s2ip+52X8YGLcli4oTxauIHkouPsIZ3rYH4/bNWLcCO2ODw3xDg tqZos94GLEZIxJHtXBZ02vmpxW6UotIEFBW3a8zmnS8mKODiSa2gU7WfG9vrwUlsZreH +uKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771910950; x=1772515750; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZEchtNVjuRATqjtl+Wbd2xxGRNm9flPdO2/cfrPLzQ=; b=eKX8XcARIJmwrmk0piPWG2MVMa9BIHRUJNCcVhrxnEnWUWJpdJXAZV9GOjtFrscCc2 0dhKTilV/0yLP3Zloy2LN3l7XRV/NjU2cBk2sGyzs126G8gIeyyx8tpVUseEmd6LE7Q3 uRX36JejJ9E+BXtLtI5gdFvHro4zjdA2b5zGFpQkfAH9nqnxJwKOkK+mx6Sj/mqa3bYZ xjxHp8mOPpT/V4M012Uearqy6mxe8Ri1VlfkTleoqLso5G6Oip3tHSABO7VkT6YujnAv QLNAiAfmrMRIkgqXd5RVqQsmXg6+x/3UUq+p9dEjRTOYAaSVNsuQP8Cuhrfo60XpvksM BMrg== X-Forwarded-Encrypted: i=1; AJvYcCUwqZAWS7Tj13UuaiLIK2DWhQCjHEbqACc2QdqYTA8W0bm3VLR7PuysD63j6VvK2zpagy2jti3QnxrggBY=@vger.kernel.org X-Gm-Message-State: AOJu0YwjHEWG6+mpN6+3uxvZmiu2r7CTu41ocMNa6elaGwuV/5fD0+ni 1h/RYR1J0Si6UyBJJAgMX2h9kkZUyCro9q1yOqqCe3WSU1PoHcIQpVN0EHUT/Q== X-Gm-Gg: ATEYQzxEwrlO37CFndJ9+ACmZIcXxWsdrVi8eoEOJjmdk4uc+heBJBVBbKv1kvtQteD uNfrPwNwZloDu8yDh/UimgpfUEvOPqlQzv0KSNCdo2qRRlDIxhtkQ5RQZglxy9mmqYoV8IvjuCw YgXDNWYTKZPYYqLdaT6HAMiJ2INYNiTgoQwC73w1pKjvPahoTPh1KalMf5Di8nk1+Q48gpcytaj ZhyCrzRnhJb5jP3vlsNZa2FHXNsLZdUoEVHVzAm0MBS5fHXs+XCY1wEJZfsvDRoiQekn6pISTZ8 pIYeS5WyUUOibK9fFXZkZ1cUtxtYfFpfsTDTiR+U9vu7xUoNApxAIJRfMEMt7S/gDQvgihZi6Xa 6eORkEVq7+C69g89pEgmp0eJ0OWCTY+PxDr9ePVHaMF/XLSMPnLXvzqvTGpvvZZKW7hJqjxKDhq CNTyED14ZDE4O4qW0WcXDi5Za1YV0xeIxzRoG1fSl+X0tFA08xt95/3uwrsS35l+uDOYehn/9kZ LvrTOWbLIuGRPCIdtggtGbINzopxEAu X-Received: by 2002:a05:693c:4097:b0:2bd:aa84:cd10 with SMTP id 5a478bee46e88-2bdaa84d31fmr418588eec.38.1771910949869; Mon, 23 Feb 2026 21:29:09 -0800 (PST) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7dbe82desm6575876eec.20.2026.02.23.21.29.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 21:29:09 -0800 (PST) Date: Mon, 23 Feb 2026 21:29:10 -0800 From: "Derek J. Clark" To: =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= , Hans de Goede CC: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_4/6=5D_platform/x86=3A_lenov?= =?US-ASCII?Q?o-wmi-other=3A_Add_GPU_tunable_attributes?= User-Agent: Thunderbird for Android In-Reply-To: <20260224043200.2680384-5-derekjohn.clark@gmail.com> References: <20260224043200.2680384-1-derekjohn.clark@gmail.com> <20260224043200.2680384-5-derekjohn.clark@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On February 23, 2026 8:31:58 PM PST, "Derek J=2E Clark" wrote: >Use an enum for all GPU attribute feature ID's and add GPU attributes=2E > >Reviewed-by: Mark Pearson >Signed-off-by: Derek J=2E Clark >--- > =2E=2E=2E/wmi/devices/lenovo-wmi-other=2Erst | 11 ++ > drivers/platform/x86/lenovo/wmi-capdata=2Eh | 1 + > drivers/platform/x86/lenovo/wmi-other=2Ec | 105 ++++++++++++++++++ > 3 files changed, 117 insertions(+) > >diff --git a/Documentation/wmi/devices/lenovo-wmi-other=2Erst b/Documenta= tion/wmi/devices/lenovo-wmi-other=2Erst >index f4763ed66cc6=2E=2Ef7564b23bb7f 100644 >--- a/Documentation/wmi/devices/lenovo-wmi-other=2Erst >+++ b/Documentation/wmi/devices/lenovo-wmi-other=2Erst >@@ -70,6 +70,17 @@ Each attribute has the following properties: > The following firmware-attributes are implemented: > - cpu_oc_stat: CPU Overlocking Status I forgot to remove CPU OC status from the documentation, reminding myself = for v4=2E > - cpu_temp: CPU Thermal Load Limit >+ - dgpu_boost_clk: Dedicated GPU Boost Clock >+ - dgpu_enable: Dedicated GPU Enabled Status >+ - gpu_didvid: GPU Device Identifier and Vendor Identifier >+ - gpu_mode: GPU Mode by Power Limit >+ - gpu_nv_ac_offset: Nvidia GPU AC Total Processing Power Baseline Offse= t >+ - gpu_nv_bpl: Nvidia GPU Base Power Limit >+ - gpu_nv_cpu_boost: Nvidia GPU to CPU Dynamic Boost Limit >+ - gpu_nv_ctgp: Nvidia GPU Configurable Total Graphics Power >+ - gpu_nv_ppab: Nvidia GPU Power Performance Aware Boost Limit >+ - gpu_oc_stat: GPU Overclocking Status Same for GPU OC Status=20 - Derek >+ - gpu_temp: GPU Thermal Load Limit > - ppt_cpu_cl: CPU Cross Loading Power Limit > - ppt_pl1_apu_spl: Platform Profile Tracking APU Sustained Power Limit > - ppt_pl1_spl: Platform Profile Tracking Sustained Power Limit >diff --git a/drivers/platform/x86/lenovo/wmi-capdata=2Eh b/drivers/platfo= rm/x86/lenovo/wmi-capdata=2Eh >index aa48f43cbb43=2E=2Eb7f9ee7b301a 100644 >--- a/drivers/platform/x86/lenovo/wmi-capdata=2Eh >+++ b/drivers/platform/x86/lenovo/wmi-capdata=2Eh >@@ -25,6 +25,7 @@ >=20 > enum lwmi_device_id { > LWMI_DEVICE_ID_CPU =3D 0x01, >+ LWMI_DEVICE_ID_GPU =3D 0x02, > LWMI_DEVICE_ID_FAN =3D 0x04, > }; >=20 >diff --git a/drivers/platform/x86/lenovo/wmi-other=2Ec b/drivers/platform= /x86/lenovo/wmi-other=2Ec >index 87aba244da84=2E=2E67768f6a50e0 100644 >--- a/drivers/platform/x86/lenovo/wmi-other=2Ec >+++ b/drivers/platform/x86/lenovo/wmi-other=2Ec >@@ -65,6 +65,19 @@ enum lwmi_feature_id_cpu { > LWMI_FEATURE_ID_CPU_IPL =3D 0x09, > }; >=20 >+enum lwmi_feature_id_gpu { >+ LWMI_FEATURE_ID_GPU_NV_PPAB =3D 0x01, >+ LWMI_FEATURE_ID_GPU_NV_CTGP =3D 0x02, >+ LWMI_FEATURE_ID_GPU_TEMP =3D 0x03, >+ LWMI_FEATURE_ID_GPU_AC_OFFSET =3D 0x04, >+ LWMI_FEATURE_ID_DGPU_BOOST_CLK =3D 0x06, >+ LWMI_FEATURE_ID_DGPU_EN =3D 0x07, >+ LWMI_FEATURE_ID_GPU_MODE =3D 0x08, >+ LWMI_FEATURE_ID_DGPU_DIDVID =3D 0x09, >+ LWMI_FEATURE_ID_GPU_NV_BPL =3D 0x0a, >+ LWMI_FEATURE_ID_GPU_NV_CPU_BOOST =3D 0x0b, >+}; >+ > #define LWMI_FEATURE_ID_FAN_RPM 0x03 >=20 > #define LWMI_TYPE_ID_NONE 0x00 >@@ -631,6 +644,66 @@ static struct tunable_attr_01 ppt_pl4_ipl_cl =3D { > =2Etype_id =3D LWMI_TYPE_ID_CROSSLOAD, > }; >=20 >+static struct tunable_attr_01 gpu_nv_ppab =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_NV_PPAB, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_nv_ctgp =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_NV_CTGP, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_temp =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_TEMP, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_nv_ac_offset =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_AC_OFFSET, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 dgpu_boost_clk =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_DGPU_BOOST_CLK, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 dgpu_enable =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_DGPU_EN, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_mode =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_MODE, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 dgpu_didvid =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_DGPU_DIDVID, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_nv_bpl =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_NV_BPL, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ >+static struct tunable_attr_01 gpu_nv_cpu_boost =3D { >+ =2Edevice_id =3D LWMI_DEVICE_ID_GPU, >+ =2Efeature_id =3D LWMI_FEATURE_ID_GPU_NV_CPU_BOOST, >+ =2Etype_id =3D LWMI_TYPE_ID_NONE, >+}; >+ > struct capdata01_attr_group { > const struct attribute_group *attr_group; > struct tunable_attr_01 *tunable_attr; >@@ -1069,6 +1142,7 @@ static int lwmi_attr_01_is_supported(struct tunable= _attr_01 *tunable_attr) > =2Ename =3D _fsname, =2Eattrs =3D _attrname##_attrs \ > } >=20 >+/* CPU tunable attributes */ > LWMI_ATTR_GROUP_TUNABLE_CAP01(cpu_temp, "cpu_temp", > "Set the CPU thermal load limit"); > LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_cpu_cl, "ppt_cpu_cl", >@@ -1094,9 +1168,40 @@ LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl, "ppt_pl= 4_ipl", > LWMI_ATTR_GROUP_TUNABLE_CAP01(ppt_pl4_ipl_cl, "ppt_pl4_ipl_cl", > "Set the CPU cross loading instantaneous power limit"); >=20 >+/* GPU tunable attributes */ >+LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_boost_clk, "gpu_boost_clk", >+ "Set the dedicated GPU boost clock"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_didvid, "gpu_didvid", >+ "Get the GPU device identifier and vendor identifier"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(dgpu_enable, "dgpu_enable", >+ "Set the dedicated Nvidia GPU enabled status"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_mode, "gpu_mode", >+ "Set the GPU mode by power limit"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ac_offset, "gpu_nv_ac_offset", >+ "Set the Nvidia GPU AC total processing power baseline offset")= ; >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_bpl, "gpu_nv_bpl", >+ "Set the Nvidia GPU base power limit"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_cpu_boost, "gpu_nv_cpu_boost", >+ "Set the Nvidia GPU to CPU dynamic boost limit"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ctgp, "gpu_nv_ctgp", >+ "Set the GPU configurable total graphics power"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_nv_ppab, "gpu_nv_ppab", >+ "Set the Nvidia GPU power performance aware boost limit"); >+LWMI_ATTR_GROUP_TUNABLE_CAP01(gpu_temp, "gpu_temp", >+ "Set the GPU thermal load limit"); >=20 > static struct capdata01_attr_group cd01_attr_groups[] =3D { > { &cpu_temp_attr_group, &cpu_temp }, >+ { &dgpu_boost_clk_attr_group, &dgpu_boost_clk }, >+ { &dgpu_didvid_attr_group, &dgpu_didvid }, >+ { &dgpu_enable_attr_group, &dgpu_enable }, >+ { &gpu_mode_attr_group, &gpu_mode }, >+ { &gpu_nv_ac_offset_attr_group, &gpu_nv_ac_offset }, >+ { &gpu_nv_bpl_attr_group, &gpu_nv_bpl }, >+ { &gpu_nv_cpu_boost_attr_group, &gpu_nv_cpu_boost }, >+ { &gpu_nv_ctgp_attr_group, &gpu_nv_ctgp }, >+ { &gpu_nv_ppab_attr_group, &gpu_nv_ppab }, >+ { &gpu_temp_attr_group, &gpu_temp }, > { &ppt_cpu_cl_attr_group, &ppt_cpu_cl }, > { &ppt_pl1_apu_spl_attr_group, &ppt_pl1_apu_spl }, > { &ppt_pl1_spl_attr_group, &ppt_pl1_spl },