From: Sachin Sant <sachinp@linux.vnet.ibm.com>
To: Odin Ugedal <odin@uged.al>, Mel Gorman <mgorman@techsingularity.net>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Ensure _sum and _avg values stay consistent
Date: Thu, 1 Jul 2021 17:15:31 +0530 [thread overview]
Message-ID: <C253482E-0B1E-4F38-92D6-6F00AFFA7DEF@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFpoUr1mpErE1Soa05p36wL1uTeojQ2mqNLJ1GKVnpJ+x-3itw@mail.gmail.com>
> On 01-Jul-2021, at 4:39 PM, Odin Ugedal <odin@uged.al> wrote:
>
> tor. 1. jul. 2021 kl. 12:34 skrev Mel Gorman <mgorman@techsingularity.net>:
>>
>> What was HEAD when you checked this? 1c35b07e6d39 was merged in the
>> 5.14-rc1 merge window so would not be in 5.13.
>
> From the kernel log it looks like he used commit dbe69e433722
> (somewhere in Linus' tree), and that should include my patch. I don't
> think the patches from Vincent in the previous thread have been posted
> properly, and I think those can fix the edge case you are seeing.
>
Sorry about the confusion. Yes I am using this code level.
commit dbe69e43372212527abf48609aba7fc39a6daa27 (HEAD -> master, origin/master, origin/HEAD)
Merge: a6eaf3850cb1 b6df00789e28
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed Jun 30 15:51:09 2021 -0700
This does contain the patch from Odin.
> This should mitigate some issues:
> https://lore.kernel.org/lkml/20210622143154.GA804@vingu-book/
>
> while
> https://lore.kernel.org/lkml/20210623071935.GA29143@vingu-book/
> might also help in some cases as well.
>
> Both of those are needed to make sure that *_avg is zero whenever *_sum is zero.
Okay, so additional patches are required to fix this problem completely.
I can help test these.
Thanks
-Sachin
next prev parent reply other threads:[~2021-07-01 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 11:18 Odin Ugedal
2021-06-24 12:16 ` Vincent Guittot
2021-06-24 13:48 ` Sachin Sant
2021-06-28 13:58 ` [tip: sched/core] " tip-bot2 for Odin Ugedal
2021-07-01 9:47 ` [PATCH] " Sachin Sant
2021-07-01 10:34 ` Mel Gorman
2021-07-01 11:09 ` Odin Ugedal
2021-07-01 11:17 ` Vincent Guittot
2021-07-01 11:45 ` Sachin Sant [this message]
2021-07-01 17:21 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C253482E-0B1E-4F38-92D6-6F00AFFA7DEF@linux.vnet.ibm.com \
--to=sachinp@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=odin@uged.al \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®