From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC851C3815B for ; Mon, 20 Apr 2020 16:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86F26206F6 for ; Mon, 20 Apr 2020 16:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dxuuu.xyz header.i=@dxuuu.xyz header.b="qkOlMFp/"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jF6OArxt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbgDTQje (ORCPT ); Mon, 20 Apr 2020 12:39:34 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:53741 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbgDTQje (ORCPT ); Mon, 20 Apr 2020 12:39:34 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D53D43FC; Mon, 20 Apr 2020 12:39:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 20 Apr 2020 12:39:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h= content-transfer-encoding:content-type:in-reply-to:date:cc :subject:from:to:message-id; s=fm3; bh=tGKhGxcuXz62vF/Dg9q0OABBh DVINldw8jc1jRGeLhc=; b=qkOlMFp/X9vY4inHxrr+E4XYt42YrXgAI81JZw9R1 h+XWc9BA3oNMV3zEIDRGsbPKO7rI+EURrl9kpHk4fs+TJu/xXcoTENeHIwjj32ry PTottywSu8CRAYsvTAR4Kf1Y8Y4P4wxxLQhCTA+7BC+SXuPRTk4QrJlatXeJcCw9 +XjJw1knDsjiSmyeDmZ4SQ8c83OQAJEmYojYZVDJ/E4nFLqr4Wje54BNJDwwDIyl 0h+Dec+u+ymCYeHbDuxnCCMfnJtFpyOx7UXFD6wWu3kNgsFI1hpKOZsovzeRILs6 LJYiKi6mZSf0uJjZFgtQ2YRL0qXHsO9rHeX4e60ubl9aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tGKhGx cuXz62vF/Dg9q0OABBhDVINldw8jc1jRGeLhc=; b=jF6OArxtd/Tba2z2ojqF/Z hOtQWDNurydWxwOQhJj5Tg7/Cql9WCs8+3d/dCMomshSceJt4UmfeURPCcpojPkU /SLItdC9QWITcrUGuipqx9WjMwvuyBsz9Ki3LhxmS/m+vb1ApvkNbzMkAgjXjwkD LsFeWak+5spj9lUfzEheJHyxDjtq+fmpwTW7idWcpGQd9z6jwpPKV4D35L167vuE gVfDTUjN7+rg6EDc14ijDaPxtjHKXNv1LSvHQR9OefcNoKz3MRzA2L82Atr0Rrjc PiZDB0D8XCy9JF36XwBOxyh066fZNTJeTexKrhe6d6bXcDe9fYETmvPZKHUNStWg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeefgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepgfgtjgffuffhvffksehtqhertddttdejnecu hfhrohhmpedfffgrnhhivghlucgiuhdfuceougiguhesugiguhhuuhdrgiihiieqnecukf hppeejfedrleefrddvgeejrddufeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepugiguhesugiguhhuuhdrgiihii X-ME-Proxy: Received: from localhost (c-73-93-247-134.hsd1.ca.comcast.net [73.93.247.134]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F2D63065C30; Mon, 20 Apr 2020 12:39:29 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20200420083046.GB28749@infradead.org> Date: Mon, 20 Apr 2020 09:37:42 -0700 Cc: , , , , , , Subject: Re: [RFC] uapi: Convert stat.h #define flags to enums From: "Daniel Xu" To: "Christoph Hellwig" Message-Id: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On Sun Apr 19, 2020 at 6:30 PM PST, Christoph Hellwig wrote: > And that breaks every userspace program using ifdef to check if a > symbolic name has been defined. How about shadowing #define's? Like for `enum nfnetlink_groups` in include/uapi/linux/netfilter/nfnetlink.h . Thanks, Daniel