From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357Ab3KESMS (ORCPT ); Tue, 5 Nov 2013 13:12:18 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:35023 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753741Ab3KESMQ convert rfc822-to-8bit (ORCPT ); Tue, 5 Nov 2013 13:12:16 -0500 Subject: Re: [PATCH 02/11] devicetree: bindings: Document Qualcomm cpus and enable-method Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=US-ASCII From: Kumar Gala In-Reply-To: <52792EF6.2040005@codeaurora.org> Date: Tue, 5 Nov 2013 12:12:14 -0600 Cc: Rob Herring , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , David Brown , Rohit Vaswani , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: 7BIT Message-Id: References: <1383343739-23080-1-git-send-email-sboyd@codeaurora.org> <1383343739-23080-3-git-send-email-sboyd@codeaurora.org> <20131104173606.GL21983@codeaurora.org> <378446F7-DC51-448D-AF99-93F98CEAFB03@codeaurora.org> <52792C60.2030405@codeaurora.org> <1A27B0E2-FB92-488D-A0B3-65E677525720@codeaurora.org> <52792EF6.2040005@codeaurora.org> To: Stephen Boyd X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 5, 2013, at 11:46 AM, Stephen Boyd wrote: > On 11/05/13 09:43, Kumar Gala wrote: >> On Nov 5, 2013, at 11:35 AM, Stephen Boyd wrote: >> >>> On 11/05/13 09:12, Kumar Gala wrote: >>>> I think this should be more specific than just 'qcom,mmio' or 'qcom,warm-boot'. It should be 'qcom,kpss-acc-v1' or 'qcom-gcc-8660'. >>>> >>> Do you have any reasons why? I don't see why we need to keep adding more >>> and more enable-methods every time the subsystem surrounding the CPU >>> changes. The method is the same, write some registers to power up the >>> CPU for the first time (cold boot) or ping the CPU to wake it up >>> (warmboot). The only difference is where those registers live and a >>> slight variation in the sequence that we perform. >> By that argument every device could just be compatible with 'mmio' and be done with it ;) >> >> As the registers you write vary, the compatible should vary. > > The compatible does vary. The enable-method is not a compatible property. > > -- I've always felt that the enable-method is equivalent of a compatible property. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation