From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965188AbbI2OOC (ORCPT ); Tue, 29 Sep 2015 10:14:02 -0400 Received: from mail-bn1bon0110.outbound.protection.outlook.com ([157.56.111.110]:41323 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964892AbbI2ONz (ORCPT ); Tue, 29 Sep 2015 10:13:55 -0400 From: Brent Adam To: Jiri Kosina CC: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings Thread-Topic: [PATCH] HID: hid-multitouch.c: fix formatting warnings Thread-Index: AQHQ+ijI3fKk4wE6nkm7A/smaC8LZ55TeOmA//+wVIA= Date: Tue, 29 Sep 2015 14:13:51 +0000 Message-ID: References: <1443470594-9878-1-git-send-email-brentadam@smarttech.com> In-Reply-To: Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/0.0.0.150923 authentication-results: spf=none (sender IP is ) smtp.mailfrom=BrentAdam@smarttech.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [72.2.16.8] x-microsoft-exchange-diagnostics: 1;BN1PR06MB200;5:Vy7OJNEVgl9UVhCo8mDbM5i0ShZjmphJaX2clkmMMlX6X6O9lBP4z8ZiMGjna0qQXxtMEJo+Qr1iL1/iGx4bdnrXnDcFrO1MElH+0YXfn30POwjRe/kWdqq6bmvdlxtx4Hfs/G1GUFV3HWz0Pgedpw==;24:2VxRsBrq7CeV6Wjeb6oOKC6uKshbl3C6jCUgAE1laD2rVWiTwW2/DLfm33dYu9hsZv0ebCguGl3Il15DXlrPbTQdwfSQomuXDBHRZjYQeWA=;20:nyXcKkxp09RyNjF7V6aRT/ztnfckYi2iyE4RLGd0ZNB3pURgUIX/GpvFwelMvQJD5eJEcykPECQfFIiz9so3RA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR06MB200; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BN1PR06MB200;BCL:0;PCL:0;RULEID:;SRVR:BN1PR06MB200; x-forefront-prvs: 0714841678 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(479174004)(24454002)(199003)(189002)(377454003)(4001350100001)(76176999)(5007970100001)(66066001)(40100003)(189998001)(5001960100002)(50986999)(36756003)(64706001)(122556002)(102836002)(15975445007)(5004730100002)(87936001)(82746002)(83506001)(81156007)(68736005)(54356999)(83716003)(110136002)(106356001)(106116001)(105586002)(4001540100001)(2950100001)(99286002)(11100500001)(19580405001)(5001860100001)(46102003)(33656002)(19580395003)(97736004)(101416001)(10400500002)(5002640100001)(80792005)(77156002)(62966003)(92566002)(86362001)(5001830100001)(2900100001)(104396002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR06MB200;H:BN1PR06MB200.namprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <30B42005729DF24F9B28D9F70B402650@namprd06.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: smarttech.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2015 14:13:51.7792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c56f9106-1d27-456d-bd20-3de87e595a36 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR06MB200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8TEE6CZ018756 On 9/29/15, 6:59 AM, "Jiri Kosina" wrote: >On Mon, 28 Sep 2015, Brent Adam wrote: > >> Fixed the following checkpatch.pl warnings: >> WARNING: line over 80 characters: line 163 >> WARNING: Missing a blank line after declarations: line 359 >> WARNING: Missing a blank line after declarations: line 572 >> WARNING: Missing a blank line after declarations: line 708 >> WARNING: Missing a blank line after declarations: line 926 >> WARNING: Possible unnecessary 'out of memory' message: line 1034 >> WARNING: Possible unnecessary 'out of memory' message: line 1048 >> WARNING: line over 80 characters: line 1390 > >For files which are already in tree I'd be taking such fixes only as a >side-change if refactoring the code anyway in a substantial way. Otherwise >I consider the ones below too minor to justify cluttering of git blame. Ok, although Greg Kroah-Hartman inspires you in his video to submit patches to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4 -Brent {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I