mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>,
	Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Claudiu Zissulescu" <claudiu.zissulescu@synopsys.com>
Subject: Re: [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too)
Date: Mon, 4 Mar 2019 22:32:00 +0000	[thread overview]
Message-ID: <C2D7FE5348E1B147BCA15975FBA230750146438D04@US01WEMBX2.internal.synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA2307501464381EE@US01WEMBX2.internal.synopsys.com>

On 2/28/19 11:24 AM, Vineet Gupta wrote:
> On 2/28/19 10:59 AM, Guenter Roeck wrote:
>>> Once the patch hits mainline you could use that. In the mean time I'll back out
>>> the "detector" as it might trip other people too.
>>>
>> Can you possibly use $(cc-option,-mno-unaligned-access), or would that
>> defeat the purpose ?
>>
> Indeed I was looking into Kconfig documentation and found something similar.
> However there's an anti-dependency. It is enabled by default and can only be
> disabled with $(cc-option,-mno-unaligned-access)
> So guess we will have to change  ARC_USE_UNALIGNED_MEM_ACCESS to
> ARC_*LACKS*_UNALIGNED_MEM_ACCESS
>
> I'll tinker a bit and post an update soon.

I got around to testing a patch with inverted option, unaligned access is default
and ARC_UNALIGNED_ACCESS_NONE disables it. This option can depend on
$(cc-option,-mno-unaligned-access). The issue however is "broken" gcc silently
ignoring -mno-unaligned-access. So this option can't be auto disable with affected
gcc. So this approach won't work. The only way out is remove the stringent check
and just wait for upstream gcc to be fixed.


      reply	other threads:[~2019-03-04 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 17:47 Guenter Roeck
2019-02-28 18:12 ` Vineet Gupta
2019-02-28 18:59   ` Guenter Roeck
2019-02-28 19:24     ` Vineet Gupta
2019-03-04 22:32       ` Vineet Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C2D7FE5348E1B147BCA15975FBA230750146438D04@US01WEMBX2.internal.synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=claudiu.zissulescu@synopsys.com \
    --cc=eugeniy.paltsev@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®