From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely
Date: Tue, 8 Apr 2014 09:18:04 +0000 [thread overview]
Message-ID: <C2D7FE5348E1B147BCA15975FBA230751AC602@IN01WEMBXA.internal.synopsys.com> (raw)
In-Reply-To: <1396947368.26620.2.camel@x220>
Hi Paul,
On Tuesday 08 April 2014 02:26 PM, Paul Bolle wrote:
> The Kconfig symbol ARC_HAS_COH_RTSC was removed in v3.13. The Kconfig
> entry for ISS_SMP_EXTN still had a select for that symbol. That select
> was just removed in commit d345ea2892ae ("ARC: Remove
> ARC_HAS_COH_RTSC").
>
> But selecting ARC_HAS_COH_RTSC was the only thing ISS_SMP_EXTN ever
> did. That means that since v3.13 setting ISS_SMP_EXTN was effectively a
> nop anyhow. So ISS_SMP_EXTN can as well be removed entirely.
There's obvious bitrot here - however this code is not dead yet !
I have a unpushed fix which uses this Kconfig item.
diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile
index a44e22ebc1b7..4d1bddc34b5b 100644
--- a/arch/arc/plat-arcfpga/Makefile
+++ b/arch/arc/plat-arcfpga/Makefile
@@ -9,4 +9,4 @@
KBUILD_CFLAGS += -Iarch/arc/plat-arcfpga/include
obj-y := platform.o irq.o
-obj-$(CONFIG_SMP) += smp.o
+obj-$(CONFIG_ISS_SMP_EXTN) += smp.o
-Vineet
next prev parent reply other threads:[~2014-04-08 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 8:56 Paul Bolle
2014-04-08 9:18 ` Vineet Gupta [this message]
2014-04-08 9:36 ` Paul Bolle
2014-04-08 10:42 ` Paul Bolle
2014-04-08 10:49 ` Vineet Gupta
2014-04-08 11:19 ` Vineet Gupta
2014-04-08 10:51 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2D7FE5348E1B147BCA15975FBA230751AC602@IN01WEMBXA.internal.synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®