From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Peter Hurley <peter@hurleysoftware.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"jslaby@suse.cz" <jslaby@suse.cz>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 2/3] serial: 8250_early: prepare for dynamic BASE_BAUD
Date: Mon, 5 Jan 2015 13:21:13 +0000 [thread overview]
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307565BC9CCD@IN01WEMBXA.internal.synopsys.com> (raw)
In-Reply-To: <54AA8AFC.9020706@hurleysoftware.com>
Hi Peter,
On Monday 05 January 2015 06:31 PM, Peter Hurley wrote:
> Hi Vineet,
>
> On 01/05/2015 06:30 AM, Vineet Gupta wrote:
>> - port->uartclk = BASE_BAUD * 16;
>> + port->uartclk = earlycon_base_baud(options) * 16;
> I don't understand why BASE_BAUD can't be defined by arc as arc_earlycon_base_baud().
> Why is the weak binding necessary?
Indeed weak semantics are not really needed - even now we have what u r suggesting
- the missing part was existing conditional definition which will simply go away
if I implement the fdt parsing in that singly defined function. Thx for the tip :-)
In that case this requires no change to driver and I can fixup the platform -
perhaps ur Ack on next version will be nice.
Also what do u think of the early IER optimization ?
>
> I'm pushing back on this because port initialization (and especially 8250)
> is already a ridiculous spiderweb.
I totally agree.
Thx,
-Vineet
>
> Regards,
> Peter Hurley
>
>> options = strchr(options, ',');
>> if (options) {
>> @@ -156,7 +165,7 @@ int __init of_setup_earlycon(unsigned long addr,
>>
>> port->iotype = UPIO_MEM;
>> port->mapbase = addr;
>> - port->uartclk = BASE_BAUD * 16;
>> + port->uartclk = earlycon_base_baud(NULL) * 16;
>> port->membase = earlycon_map(addr, SZ_4K);
>>
>> early_console_dev.con->data = &early_console_dev;
>>
>
next prev parent reply other threads:[~2015-01-05 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 11:30 [PATCH v2 0/3] Early 8250 fixlets Vineet Gupta
2015-01-05 11:30 ` [PATCH v2 1/3] serial: 8250_early: optimize early 8250 uart Vineet Gupta
2015-01-05 11:30 ` [PATCH v2 2/3] serial: 8250_early: prepare for dynamic BASE_BAUD Vineet Gupta
2015-01-05 13:00 ` Peter Hurley
2015-01-05 13:21 ` Vineet Gupta [this message]
2015-01-05 13:33 ` Peter Hurley
2015-01-05 13:52 ` Vineet Gupta
2015-01-05 14:05 ` Peter Hurley
2015-01-05 11:30 ` [PATCH v2 3/3] ARC: runtime determine BASE_BAUD per machine Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2D7FE5348E1B147BCA15975FBA2307565BC9CCD@IN01WEMBXA.internal.synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®