From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757211AbbJINl1 (ORCPT ); Fri, 9 Oct 2015 09:41:27 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:40066 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755643AbbJINl0 convert rfc822-to-8bit (ORCPT ); Fri, 9 Oct 2015 09:41:26 -0400 From: Vineet Gupta To: "Kirill A. Shutemov" CC: Andrew Morton , "Kirill A. Shutemov" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code Thread-Topic: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code Thread-Index: AQHRApdLLtVRiE5QkEuGwUT7cQnuSA== Date: Fri, 9 Oct 2015 13:39:31 +0000 Message-ID: References: <1444391029-25332-1-git-send-email-vgupta@synopsys.com> <5617BB4A.4040704@synopsys.com> <20151009133450.GA8597@node> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 09 October 2015 07:04 PM, Kirill A. Shutemov wrote: On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote: > On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote: > > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > > level #ifdef. Makes code more readable > > > > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG() > > > > Signed-off-by: Vineet Gupta > > Sorry for sounding pushy - an Ack here will unblock me from dumping boat load of > patches into linux-next via my tree ! I hope you've tested it with different .configs... Acked-by: Kirill A. Shutemov Atleast 2 configs with CONFIG_TRANSPARENT_HUGEPAGE on and off - for ARC ! I can test some more if u point me to.