From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbbKIKWc (ORCPT ); Mon, 9 Nov 2015 05:22:32 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:55229 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbbKIKWb convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 05:22:31 -0500 From: Vineet Gupta To: Peter Zijlstra , Noam Camus CC: "gilf@ezchip.com" , "linux-snps-arc@lists.infradead.org" , "talz@ezchip.com" , "linux-kernel@vger.kernel.org" , "cmetcalf@ezchip.com" Subject: Re: [PATCH v2 16/19] ARC: [plat-eznps] Use dedicated cpu_relax() Thread-Topic: [PATCH v2 16/19] ARC: [plat-eznps] Use dedicated cpu_relax() Thread-Index: AQHRGUuT7JzxCpil1kuYt5g+JsF4lA== Date: Mon, 9 Nov 2015 10:22:27 +0000 Message-ID: References: <1446297327-16298-1-git-send-email-noamc@ezchip.com> <1446893557-29748-17-git-send-email-noamc@ezchip.com> <20151109100503.GH17308@twins.programming.kicks-ass.net> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 November 2015 03:35 PM, Peter Zijlstra wrote: > On Sat, Nov 07, 2015 at 12:52:34PM +0200, Noam Camus wrote: >> diff --git a/arch/arc/include/asm/processor.h b/arch/arc/include/asm/processor.h >> index 7266ede..50f9bae 100644 >> --- a/arch/arc/include/asm/processor.h >> +++ b/arch/arc/include/asm/processor.h >> @@ -58,12 +58,21 @@ struct task_struct; >> * get optimised away by gcc >> */ >> #ifdef CONFIG_SMP >> +#ifndef CONFIG_EZNPS_MTM_EXT >> #define cpu_relax() __asm__ __volatile__ ("" : : : "memory") >> #else >> +#define cpu_relax() \ >> + __asm__ __volatile__ (".word %0" : : "i"(CTOP_INST_SCHD_RW) : "memory") >> +#endif >> +#else >> #define cpu_relax() do { } while (0) > I'm fairly sure this is incorrect. Even on UP we expect cpu_relax() to > be a compiler barrier. We discussed this a while back (why do https:/lkml.org/lkml//.... links work psuedo randomly) http://marc.info/?l=linux-kernel&m=140350765530113 > >> #endif >> >> +#ifndef CONFIG_EZNPS_MTM_EXT >> #define cpu_relax_lowlatency() cpu_relax() >> +#else >> +#define cpu_relax_lowlatency() barrier() >> +#endif > At which point you can unconditionally use that definition. > >> >> #define copy_segments(tsk, mm) do { } while (0) >> #define release_segments(mm) do { } while (0) >> -- >> 1.7.1 >> > _______________________________________________ > linux-snps-arc mailing list > linux-snps-arc@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-snps-arc >