From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbcEDOCB (ORCPT ); Wed, 4 May 2016 10:02:01 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:36229 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcEDOB7 convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2016 10:01:59 -0400 From: Vineet Gupta To: Thomas Petazzoni , Peter Zijlstra CC: Nicolas Pitre , Andrew Morton , David Hildenbrand , Russell King , lkml , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" Subject: Re: kmap_atomic and preemption Thread-Topic: kmap_atomic and preemption Thread-Index: AQHRpguLQaT1OLCvj0eensd2wdsxXA== Date: Wed, 4 May 2016 14:01:52 +0000 Message-ID: References: <5729D0F4.9090907@synopsys.com> <20160504134729.GP3430@twins.programming.kicks-ass.net> <20160504155345.5fdd366e@free-electrons.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 May 2016 07:23 PM, Thomas Petazzoni wrote: > Hello, > > On Wed, 4 May 2016 15:47:29 +0200, Peter Zijlstra wrote: > >> static inline void *kmap_atomic(struct page *page) >> { >> preempt_disable(); >> pagefault_disable(); >> if (!PageHighMem(page)) >> return page_address(page); >> >> return __kmap_atomic(page); >> } > This is essentially what has been done on ARM in commit > 9ff0bb5ba60638a688a46e93df8c5009896672eb, showing a pretty significant > improvement in network workloads. ARC already has that semantically - only not inline ! I really want to avoid 2 needless LD-ADD-ST for the disabling of preemption and page fault for the low mem pages by returning early ! static inline void *kmap_atomic(struct page *page) { if (!PageHighMem(page)) return page_address(page); preempt_disable(); pagefault_disable(); return __kmap_atomic(page); } > > Best regards, > > Thomas