From: Nadav Amit <namit@vmware.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S
Date: Fri, 16 Nov 2018 20:18:58 +0000 [thread overview]
Message-ID: <C359F0E6-2920-428F-B93E-7C76E564C1BA@vmware.com> (raw)
In-Reply-To: <CAK7LNAR30CVQHBTXzY-cFcpa-mw2QSpqUZHEAs7n0Jn64dLBFw@mail.gmail.com>
From: Masahiro Yamada
Sent: November 16, 2018 at 7:37:46 AM GMT
> To: Nadav Amit <namit@vmware.com>
> Cc: Ingo Molnar <mingo@redhat.com>, Michal Marek <michal.lkml@markovi.net>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, H. Peter Anvin <hpa@zytor.com>, X86 ML <x86@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S
>
>
> On Thu, Nov 15, 2018 at 1:01 PM Nadav Amit <namit@vmware.com> wrote:
>> Changes in macros.S should trigger the recompilation of all C files, as
>> the macros might need to affect their compilation.
>>
>> Acked-by: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>
> When we talked about this last time,
> we agreed to not do this
> because a single line change in asm headers
> would cause global rebuilding.
>
> Did you change your mind?
I was wrong (and you were right? I don’t quite remember). Anyhow, another
patch I work on made me realize how wrong I was.
If required, we can extract the macros from some of the header files into
separate header files to prevent unnecessary rebuilds.
Thanks,
Nadav
prev parent reply other threads:[~2018-11-16 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 20:43 [PATCH v2 0/2] x86: Asm macros fixes Nadav Amit
2018-11-14 20:43 ` [PATCH v2 1/2] Makefile: Fix distcc compilation with x86 macros Nadav Amit
2018-11-16 7:45 ` Masahiro Yamada
2018-11-16 21:01 ` Nadav Amit
2018-11-18 4:20 ` Masahiro Yamada
2018-11-19 17:18 ` Nadav Amit
2018-11-21 2:47 ` Masahiro Yamada
2018-11-14 20:43 ` [PATCH v2 2/2] x86: set a dependency on macros.S Nadav Amit
2018-11-16 7:37 ` Masahiro Yamada
2018-11-16 20:18 ` Nadav Amit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C359F0E6-2920-428F-B93E-7C76E564C1BA@vmware.com \
--to=namit@vmware.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®