From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbdBBHu2 convert rfc822-to-8bit (ORCPT ); Thu, 2 Feb 2017 02:50:28 -0500 Received: from mga07.intel.com ([134.134.136.100]:27506 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbdBBHu1 (ORCPT ); Thu, 2 Feb 2017 02:50:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="1121048759" From: "Dilger, Andreas" To: Arnd Bergmann CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "Eremin, Dmitry" , Lustre Development List , "devel@driverdev.osuosl.org" , LKML Subject: Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Thread-Topic: [PATCH] staging: lustre: shut up clang warnings on CLASSERT() Thread-Index: AQHSfKvQtWFDl8GADkSeTLt4M2Egl6FV3siA Date: Thu, 2 Feb 2017 07:50:24 +0000 Message-ID: References: <20170201165314.2588373-1-arnd@arndb.de> In-Reply-To: <20170201165314.2588373-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.92.61] Content-Type: text/plain; charset="us-ascii" Content-ID: <95CEFDC6FF17734A917FACAE84789C49@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 1, 2017, at 09:52, Arnd Bergmann wrote: > > lustre uses a fake switch() statement as a compile-time assert, but unfortunately > each use of that causes a warning when building with clang: > > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case matching constant switch condition '42' > drivers/staging/lustre/lnet/klnds/socklnd/../../../include/linux/libcfs/libcfs_private.h:294:36: note: expanded from macro 'CLASSERT' > #define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0) > > Adding a 'default:' label in there shuts up the warning. > > Signed-off-by: Arnd Bergmann Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > index aab15d8112a4..2d5435029185 100644 > --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > @@ -291,7 +291,7 @@ do { \ > * value after conversion... > * > */ > -#define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0) > +#define CLASSERT(cond) do {switch (42) {case (cond): case 0: default: break; } } while (0) > > /* max value for numeric network address */ > #define MAX_NUMERIC_VALUE 0xffffffff > -- > 2.9.0 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation