From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759389Ab1LPHT7 (ORCPT ); Fri, 16 Dec 2011 02:19:59 -0500 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:46029 "EHLO VA3EHSOBE007.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756067Ab1LPHT5 convert rfc822-to-8bit (ORCPT ); Fri, 16 Dec 2011 02:19:57 -0500 X-SpamScore: -15 X-BigFish: VPS-15(zz9371I542M1432N98dKzz1202hzz8275bhz2dh2a8h668h839h8e2h8e3h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:59.163.77.45;KIP:(null);UIP:(null);IPV:NLI;H:Outbound.kpitcummins.com;RD:59.163.77.45.static.vsnl.net.in;EFVD:NLI From: Ashish Jangam To: Grant Likely CC: Stephen Rothwell , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown , Dajun Subject: RE: linux-next: build failure after merge of the regmap tree Thread-Topic: linux-next: build failure after merge of the regmap tree Thread-Index: AQHMu1bjcS+h6HxWskeAYdU7g1Upj5XeDlvg Date: Fri, 16 Dec 2011 07:19:50 +0000 Message-ID: References: <1323941146.32031.49.camel@dhruva> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.38.22] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: kpitcummins.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely Sent: Thursday, December 15, 2011 11:55 PM To: Ashish Jangam Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Brown; Dajun Subject: Re: linux-next: build failure after merge of the regmap tree On Thu, Dec 15, 2011 at 2:25 AM, Ashish Jangam wrote: > Fixes DA9052 GPIO errors. > > This patch is functionally tested on Samsung SMDKV6410. > > Signed-off-by: David Dajun Chen > Signed-off-by: Ashish Jangam > --- >  drivers/gpio/gpio-da9052.c      |   37 ++++-------------------------- >  include/linux/mfd/da9052/gpio.h |   48 +++++++++++++++++++++++++++++++++++++++ gpio-da9052.c is the only users of mfd/da9052/gpio.h. Why is this include file needed? The #defines can simply stay in the .c file. I've picked up the patch, but modified it to keep the header defines in the .c file. If there is a reason this won't work, then please let me know. This header file is shared between GPIO and LED module. I have already posted this LED long back got ACK but did not got merged due to its dependency on MFD module. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.