From: zhang warden <zhangwarden@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure
Date: Sun, 25 Aug 2024 22:37:06 +0800 [thread overview]
Message-ID: <C3B45B71-C7D1-45EB-B749-39514A49C521@gmail.com> (raw)
In-Reply-To: <Zsq3g4HE4LWcHHDb@infradead.org>
> On Aug 25, 2024, at 12:48, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, Aug 22, 2024 at 11:01:58AM +0800, Wardenjohn wrote:
>> 1. Move klp_ops into klp_func structure.
>> Rewrite the logic of klp_find_ops and
>> other logic to get klp_ops of a function.
>>
>> 2. Move definition of struct klp_ops into
>> include/linux/livepatch.h
>
> Why?
>
Hi, Christoph.
When introducing feature of "using", we should handle the klp_ops check.
In order to get klp_ops from transition, we may have more complex logic for
checking.
If we move klp_ops into klp_func. We can remove the global list head of klp_ops.
What's more, there are some code in livepatch should get function's ops.
With this feature, we don't need the original search to the one ops.
It can be simple and straightforward.
Regards,
Wardenjohn
next prev parent reply other threads:[~2024-08-25 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 3:01 [PATCH v3 0/2] livepatch: Add using attribute to klp_func for using function Wardenjohn
2024-08-22 3:01 ` [PATCH v3 1/2] Introduce klp_ops into klp_func structure Wardenjohn
2024-08-25 4:48 ` Christoph Hellwig
2024-08-25 14:37 ` zhang warden [this message]
2024-08-25 20:17 ` Jiri Kosina
2024-08-26 3:31 ` zhang warden
2024-08-22 3:01 ` [PATCH v3 2/2] livepatch: Add using attribute to klp_func for using function show Wardenjohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3B45B71-C7D1-45EB-B749-39514A49C521@gmail.com \
--to=zhangwarden@gmail.com \
--cc=hch@infradead.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®