From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD2DC43331 for ; Sat, 7 Sep 2019 14:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3E782178F for ; Sat, 7 Sep 2019 14:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394688AbfIGOsc convert rfc822-to-8bit (ORCPT ); Sat, 7 Sep 2019 10:48:32 -0400 Received: from mxout014.mail.hostpoint.ch ([217.26.49.174]:36075 "EHLO mxout014.mail.hostpoint.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391160AbfIGOsb (ORCPT ); Sat, 7 Sep 2019 10:48:31 -0400 Received: from [10.0.2.46] (helo=asmtp013.mail.hostpoint.ch) by mxout014.mail.hostpoint.ch with esmtp (Exim 4.92.2 (FreeBSD)) (envelope-from ) id 1i6c0k-0001B0-95; Sat, 07 Sep 2019 16:48:22 +0200 Received: from 145-126.cable.senselan.ch ([83.222.145.126] helo=[192.168.1.99]) by asmtp013.mail.hostpoint.ch with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2 (FreeBSD)) (envelope-from ) id 1i6c0k-000Oar-4s; Sat, 07 Sep 2019 16:48:22 +0200 X-Authenticated-Sender-Id: sandro@volery.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT From: Sandro Volery Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] Fixed parentheses malpractice in apex_driver.c Date: Sat, 7 Sep 2019 16:48:21 +0200 Message-Id: References: <20190907143849.GA30834@kadam> Cc: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org In-Reply-To: <20190907143849.GA30834@kadam> To: Dan Carpenter X-Mailer: iPhone Mail (17A5572a) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 7 Sep 2019, at 16:39, Dan Carpenter wrote: > > You need a subject prefix. It should be something like: > > [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c > Thanks for the reply! I'll try to do that better for my next patch. > Generally "Fix" is considered better style than "Fixed". We aren't > going to care about that in staging, but the patch prefix is mandatory > so you will need to redo it anyway and might as well fix that as well. > >> On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote: >> There were some parentheses at the end of lines, which I took care of. >> This is my first patch. > ^^^^^^^^^^^^^^^^^^^^^^ > Put this sort of comments after the --- cut off line > >> >> Signed-off-by: Sandro Volery >> --- > ^^^ > Put it here. It will be removed when we apply the patch so it won't > be recorded in the git log. > Alright :) >> drivers/staging/gasket/apex_driver.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Joe's comments are, of course, correct as well. > > regards, > dan carpenter > I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda bad tho if I just apply his work and send it in? - Sandro Volery