From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2055.outbound.protection.outlook.com [40.107.223.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A71481B3 for ; Wed, 15 Jan 2025 15:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953563; cv=fail; b=L1ZZbu4nDgn//fnWcRsOt6PpaauxI+ZFv1+z6DIZrN4Qjo00tCiGlytzJ4D21CDdyI1eXaDNvmOYzRhoAo/H8IHvEmq0kFLqi894/ap0bnuOLJeKSt+FyP+3+MobTuErp8MJ8FujzTopIuwtTJy/kNnLQB4Jgw4Kpj1lP8asjEc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953563; c=relaxed/simple; bh=r2kArUxAKjTSN4T89E5PDxmmbSw0EPVgd+uwbCLyb9Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=U/GQVx3PpVdiv7+dn6Hjh8jFEM4fQaTQaqtS0zcszBUf0F1AxW/KX+7G2k1TpNyWbxdilhvyUguVVCwQofg2IIuS62nK/DMxmQZO6XQ7D+IriuzYVkS8vKRLOnbYonboP6Pk1NNxfZHWUqTcLE0nf8ic6X2L9DkOuBx6ppVljlM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=c0h2au1K; arc=fail smtp.client-ip=40.107.223.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="c0h2au1K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JtCor0BiqvF1zoUnJohQ+8+P4fgYCXuurjLXRvhQt62wMNhSEwwo8VQzMx2md8pf5ZdSxzy15lssLkc6PsZY/GpsMyJI2MYdyYTSG1hOxBhiROchMPWrwAefm7MjOgnH3Nj4DLhjJ96H6msLbmYfQdlXKe9SCf9mZa4wlxaiVr/BYPUc1V3+z2iE2caDx2giVqaz6V9d5QyacQT0nKU8K8bnSKTRRUecrNHOOJ8mwa1VBEEdAXAubVXarQqKs3VN+YyHc/pRUrY5Yu8woWnL19SqunmeM0vdNKoQQgxsC+ru2Jvh589CbLaPU4AO1bnJfb8i2gxbdsdCxHhQg+bs/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WrilVKb5wWeLf3vnYO2NT6uXJf7XqBH/53+vdS03rXM=; b=GTI222cg6Zl6EbnnKRqxVorFTLl+dv+gIEf5H9T0ODug/1tNLlgOETu5Al0Uv55C65rQKN1RLMcbDzPQjYkfHXEhpSC6Pbc4gZGadr92OK9vEb49LpKfMj/pm6VD5/pQEGqMCJOAGDabogCwAFfBTucD39qtSi+7DjJRpO25szN2suHEgMm0FRPFOnstBhsIi9ppXYOGiNDOJwBKdRe75bYxW8n2TQLjmIXsbpuFwgVO/SJtnFPsmBa/QFWvfR970gMlBjKOticCptcDzeNfUZJS2ep8DFKIQv1+3HpYERa9AGsMerYX9kDF1T1i0z1+cPJslODzuPvuyJJkBLIoIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WrilVKb5wWeLf3vnYO2NT6uXJf7XqBH/53+vdS03rXM=; b=c0h2au1K8BVC2IH/9PorK0IYPBklY+ey5uKh7cD0app7lTaFMxJ7kMlgbHHGLAAqO5mk+tCOtj52mEl1VHtAv7c+Ut5yYZyF6YcEJQ4NLlgpQuBQ6bI02m2LekGgqhAIaSNAyewQ06fpASMbITehjrmNLGZqeP+ovvK1X/pvmCb+3wh3LnRULzW6ae4EhV5ar4RVuO+z7LJKNlW/AYwWUFvMJzZXKP7J1+gbQcnVmHqIfeehCoN5ry5NAM+Ui1vLl/9wj76Pv010hA6RHY1Tnt9iVsAfkiuA0R+bec53LAPYkexVErcsvDoipOu9r5VZJiW/McmxhpB1OZl6HOzMOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH2PR12MB4167.namprd12.prod.outlook.com (2603:10b6:610:7a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 15:05:58 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%3]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 15:05:58 +0000 From: Zi Yan To: Byungchul Park Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, shivankg@amd.com Subject: Re: [PATCH v2] mm: separate move/undo parts from migrate_pages_batch() Date: Wed, 15 Jan 2025 10:05:57 -0500 X-Mailer: MailMate (2.0r6203) Message-ID: In-Reply-To: <20250115103403.11882-1-byungchul@sk.com> References: <20250115095343.46390-1-byungchul@sk.com> <20250115103403.11882-1-byungchul@sk.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR04CA0020.namprd04.prod.outlook.com (2603:10b6:208:d4::33) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH2PR12MB4167:EE_ X-MS-Office365-Filtering-Correlation-Id: 669a5f85-682f-49f3-5fb1-08dd35761e5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0rmu194VTo0OTOEubPk+jZNbs3QtF41xt6xp2IrT4phDYbLTIXwVidJ8Ekwe?= =?us-ascii?Q?Nz9BF52O17Ui+J5RT4Gtb2LEjNZ5Ki3bGv8D7h1JTNV1aCTgrFcJ9dlLlwWY?= =?us-ascii?Q?GdRZx/eCQl1r5xZmlglzCTrsfhn65abVlCjgtfR4ySjsJoepnHoSFnAT2Krc?= =?us-ascii?Q?5RXuoZ+jopjyUbjIScDTRfvQNfk3SOwilFgCeuU9qd8MD0vGBdLYM2M21zg0?= =?us-ascii?Q?lORlHEdWFtY/SwLKX3LoqK19Hw2kbqg0TEQJTpTyczfEQ/3EIBNMdUacbU48?= =?us-ascii?Q?KCHwIS5FjS0swpBdYENlpX2gp6pS7h99uelr0WWdHUQTSTWXgNS7PpDNTCKF?= =?us-ascii?Q?h0FM6b4qeE97zJqLKZWCq6tks9p28rPqIxAnpzZ7IYXPO2NQNDcadXiTYlSK?= =?us-ascii?Q?LugqyTRwkbdyTa/bAW9lU/dXruSzUwqhBGGk+82pnPMuUTGhAaOQILamKMf+?= =?us-ascii?Q?05lR/6eflAmozT1UB4Dbm/GWlRCrGkejjUVb3Xn3JayGUqPCr+fcy8x9/fKh?= =?us-ascii?Q?0o3/o7hplYI7YCH2fAgsUXAwV4hLeVMuoEEgwq/tQyezITXv/SUDHjwHjXAC?= =?us-ascii?Q?CNjL20/UIiMtAPQbInSou8lL3TPQTiQz2xTatsaeX6IM+yBHEgpSkhav26hy?= =?us-ascii?Q?1fPfG+f06s3Nqc9Or5Ksz5kSZBIJdPcNoOOUpIkrQoH1NrUto35Sjk13+cEl?= =?us-ascii?Q?Cj+IKPVz2LgG5ZAKsGbW6wCU9m8vHVpP9a2OR97xL+zl2O0QhvuWyrn58pdI?= =?us-ascii?Q?/XgTyzF2KJI/ZPepnlqjlAHXdyVFQowKFnNbtE9HWb9d8iH1FuZ3Q+T6pe5g?= =?us-ascii?Q?2ljg/vBTcFvUm9MjC/HpbmETs5doptReoBE6gw6jC0WnVurXqA7wDa3eUcr4?= =?us-ascii?Q?EoA78XlCIsd3FIJPX5JJs5uE0pSIxZwXtV6bRnbZ3J+sqbmqHhMMu6L2TvCM?= =?us-ascii?Q?gx9CIxkMpj2QMdTlmpsg9gbxAxIujhPQeTzv1kvGziS7JepYdSfsruFrnojV?= =?us-ascii?Q?N1GQ4FUuj/YqPZP3QYqgosCzpXunXk0OYRRYIWoaClHL4TBWKshyjbDz/rFr?= =?us-ascii?Q?HcJ/Zvrb4MN2FueMl4gECQxaOXF4qpM+BpRSjlRTa2nSSfjU1Yw93QvDZaOa?= =?us-ascii?Q?VhXSTtXnSoZg/NeNJ6J1PHQGlp94Ij+bz0RxLeR1g6jBLS8iF4/J2erC5GqM?= =?us-ascii?Q?oA64z1ZU+AtIyfXBGAChIXcgQ4sd9hvtKXc8Q0UEYtb0LGdmtct/J+thpSxd?= =?us-ascii?Q?Vxht+VhKt8XoAf32Uvw6RgN1ln0YzA5Yo/SteYWaOw7NbZaQdpj2OEKvtgKb?= =?us-ascii?Q?RnRXiMDnMusIIuDnoWWHCRthzZAnA1Ni2yW4Dt/kmDHQXy4KEVg1XKJCyEA6?= =?us-ascii?Q?hyFiJe+JjfvuEnEHsXX2yqGLLAM/?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zvkH27bvaDhNAOorVqXt5M2C4es8ZNAa1XxT37Ay4Jd+2JQnlVFLkgxmKaUS?= =?us-ascii?Q?gfOjJ6hBeJtpJJMCe56siIOaaQ+4rigiQJVnUCyT/U9j5oYshtcVu9rLnozf?= =?us-ascii?Q?f2RMU1Bz3+wlo4XJ3wtYRU8Fc+oO2hPRjLMqN05dIyRWjefR325af9gqXgHl?= =?us-ascii?Q?im79YaeKOc3UDc7YoWKtO9pSZpD4J4T9S493VOqiT0XYpjHPbeCZKwI4y3uE?= =?us-ascii?Q?+aqIZHMvNqLw83EGI1ouGXxjzpIjzlc+jXPoBYjNyFyOdVcYbLk2pEdSQ/6c?= =?us-ascii?Q?wWzAfHtHGV8ztr2nhQJQpaY4aZz5pGcjD/ObUT+kjytlS+Z9+JDthRPZTQEs?= =?us-ascii?Q?V5Kmy5617MHZT+Mwm3r5KRKXoAziZfSxccsHty6q3E5fZ2JTsXObrM5fhNPX?= =?us-ascii?Q?ycHNbAiN8VZG87u3WsgwTv1OOFvHlVyxPZuRzaw4f4O8DrCbosqUXy9RyXRF?= =?us-ascii?Q?bZv8Ssho9eYhTHZYRaT+7tLrCyxAruT2D8Ryau/uEJD+wkDDePyk5IR401xD?= =?us-ascii?Q?6djKWvB/1Gn3hgsQnAajh+Q6MoPNtc1FGZPOr2DngqxxIXdckbuQ+QIJC6Th?= =?us-ascii?Q?b0RF/YYTQqllCIHqE8a+0jyUkDd/8Z19as/rWfVSXZw2ejn7XcgQgJAzXFqO?= =?us-ascii?Q?on5VPREilWcthFEFBA24A6ddtThkT1cfgQb+IQhLbP9HF+JzTgHEPSdNNTVy?= =?us-ascii?Q?sdkGJK/7oR5Db1UwRE+w3PrYWL/UVH0Nrmixh+d0kBjg3GT/rIMu2mAc2TY5?= =?us-ascii?Q?1LSCHzcR4La/HbY7OlAFqDsYCbIPENzlTAnVMofJNXZOilORbvWkIvAXGua/?= =?us-ascii?Q?3AtCdnAsxhe5MWFh9n591MJOwx5/b35tzTu0VvNUSAqTN4ed3tmBzmP1Go6i?= =?us-ascii?Q?IFKs57aFPEVpD8c9TPq9I5qplJbxfkky76ZTeZ6zjHw7B3zCz1fL8/YIe8s7?= =?us-ascii?Q?BlmcbH7w+wtZrbl1eBNctjo7/y6x3LVNlkW1cpYF9Lvoim4VeF14bY6WuZM/?= =?us-ascii?Q?EqK5xfwL7Kdps87wgtwyBPGLa7WQgjBT7zqGuCoCx+lISFqATTtAr78yZSMV?= =?us-ascii?Q?lHcmzD15fj70J5JrKWmZg+dEUzL7j0MHjaJjPxM1KmZwnEirAa2e38yrJPbM?= =?us-ascii?Q?Njz6DapujoA44oVf+VEqDKT6bQpgdutTx6ZmDzLox0uqoQJpFlnQlLi6hUWr?= =?us-ascii?Q?/XqnkN1y3I/+kiFMw9XPYgqqv2PdA8BRRPxWdFYixnp99kqrG2pP3cBTp6MS?= =?us-ascii?Q?Wfu7TCXn0UBR0ubCpLnKb48+oD5AF8vfAvEQiweqpMCp7hfRAvdvnULHkke7?= =?us-ascii?Q?PlbF8/3a7CuqeS1NPrmTYOgFqD8E9hOB2xTmMI/mC6uo615jpyjrSiOUNu4A?= =?us-ascii?Q?pUZaPCsAeSc47CkoxfgJInye47n4g/IciHv0sz06KDGaLk8inQPinOS2TCVe?= =?us-ascii?Q?Uod4ZP7he4LI/lfXEjOBlSTxP5jZ+lbZcq4qFxOkt2PpM3GH+wlclwVz+odc?= =?us-ascii?Q?kS4jpLnKiDfav8C6kWeI8hZSRJXVn72aW9qAG2chnkdCDbaulL9EFRMX8OEg?= =?us-ascii?Q?LWuPaX/xwbBpDhVJQdocbA5Ki0urij82gl99kCw8?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 669a5f85-682f-49f3-5fb1-08dd35761e5b X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 15:05:58.9175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WyG0zJ5HpJogbEVA7RfXlsvPldXPtWLuORWPJx3OtV6PWeDraChdxgJz9E/R+vIZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4167 On 15 Jan 2025, at 5:34, Byungchul Park wrote: > Changes from v1 > - Fix a wrong coding style > = > --->8--- > From a65a6e4975962707bf87171e317f005c6276887e Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Thu, 8 Aug 2024 15:53:58 +0900 > Subject: [PATCH v2] mm: separate move/undo parts from migrate_pages_bat= ch() > > Functionally, no change. This is a preparation for luf mechanism that > requires to use separated folio lists for its own handling during > migration. Refactored migrate_pages_batch() so as to separate move/und= o > parts from migrate_pages_batch(). > > Signed-off-by: Byungchul Park > Reviewed-by: Shivank Garg > --- > mm/migrate.c | 134 +++++++++++++++++++++++++++++++--------------------= > 1 file changed, 83 insertions(+), 51 deletions(-) > LGTM. Reviewed-by: Zi Yan I am planning to send the batching page copy part in my page migration acceleration patchset separately for upstream first, so that we can focus on the page copy acceleration, using multithreads and DMA afterwards. Best Regards, Yan, Zi