From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756202AbcBCGW5 (ORCPT ); Wed, 3 Feb 2016 01:22:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbcBCGW4 convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2016 01:22:56 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH 08/10] fs: ceph: replace CURRENT_TIME by current_fs_time() From: "Yan, Zheng" In-Reply-To: <1454479670-8204-9-git-send-email-deepa.kernel@gmail.com> Date: Wed, 3 Feb 2016 14:22:41 +0800 Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, Arnd Bergmann , Dave Chinner , "Theodore Ts'o" , linux-kernel , Sage Weil , Ilya Dryomov , ceph-devel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1454479670-8204-1-git-send-email-deepa.kernel@gmail.com> <1454479670-8204-9-git-send-email-deepa.kernel@gmail.com> To: Deepa Dinamani Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 3, 2016, at 14:07, Deepa Dinamani wrote: > > CURRENT_TIME macro is not appropriate for filesystems as it > doesn't use the right granularity for filesystem timestamps. > Use current_fs_time() instead. > > Signed-off-by: Deepa Dinamani > Cc: "Yan, Zheng" > Cc: Sage Weil > Cc: Ilya Dryomov > Cc: ceph-devel@vger.kernel.org applied, thanks Yan, Zheng > --- > fs/ceph/file.c | 4 ++-- > fs/ceph/inode.c | 2 +- > fs/ceph/xattr.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index 86a9c38..9b338ff 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -783,7 +783,7 @@ ceph_direct_read_write(struct kiocb *iocb, struct iov_iter *iter, > int num_pages = 0; > int flags; > int ret; > - struct timespec mtime = CURRENT_TIME; > + struct timespec mtime = current_fs_time(inode->i_sb); > size_t count = iov_iter_count(iter); > loff_t pos = iocb->ki_pos; > bool write = iov_iter_rw(iter) == WRITE; > @@ -988,7 +988,7 @@ ceph_sync_write(struct kiocb *iocb, struct iov_iter *from, loff_t pos, > int flags; > int check_caps = 0; > int ret; > - struct timespec mtime = CURRENT_TIME; > + struct timespec mtime = current_fs_time(inode->i_sb); > size_t count = iov_iter_count(from); > > if (ceph_snap(file_inode(file)) != CEPH_NOSNAP) > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index fb4ba2e..63d0198 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -1959,7 +1959,7 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) > if (dirtied) { > inode_dirty_flags = __ceph_mark_dirty_caps(ci, dirtied, > &prealloc_cf); > - inode->i_ctime = CURRENT_TIME; > + inode->i_ctime = current_fs_time(inode->i_sb); > } > > release &= issued; > diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c > index 819163d..1e1c00a 100644 > --- a/fs/ceph/xattr.c > +++ b/fs/ceph/xattr.c > @@ -999,7 +999,7 @@ retry: > dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_XATTR_EXCL, > &prealloc_cf); > ci->i_xattrs.dirty = true; > - inode->i_ctime = CURRENT_TIME; > + inode->i_ctime = current_fs_time(inode->i_sb); > } > > spin_unlock(&ci->i_ceph_lock); > @@ -1136,7 +1136,7 @@ retry: > dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_XATTR_EXCL, > &prealloc_cf); > ci->i_xattrs.dirty = true; > - inode->i_ctime = CURRENT_TIME; > + inode->i_ctime = current_fs_time(inode->i_sb); > spin_unlock(&ci->i_ceph_lock); > if (lock_snap_rwsem) > up_read(&mdsc->snap_rwsem); > -- > 1.9.1 >