mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Allen Pais <apais@linux.microsoft.com>
To: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Guixin Liu <kanie@linux.alibaba.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	Sheng Yang <sheng@yasker.org>,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] scsi: target: tcm_loop: fix segfault in tcm_loop_tpg_address_show()
Date: Thu, 6 Nov 2025 07:56:24 -0800	[thread overview]
Message-ID: <C4A5B08B-27E4-4ACF-96E4-9351F0BFF320@linux.microsoft.com> (raw)
In-Reply-To: <1762370746-6304-1-git-send-email-hamzamahfooz@linux.microsoft.com>



> On Nov 5, 2025, at 11:25 AM, Hamza Mahfooz <hamzamahfooz@linux.microsoft.com> wrote:
> 
> If the allocation of tl_hba->sh fails in tcm_loop_driver_probe() and we
> attempt to dereference it in tcm_loop_tpg_address_show() we will get a
> segfault, see below for an example. So, check tl_hba->sh before
> dereferencing it.
> 
> Unable to allocate struct scsi_host
> BUG: kernel NULL pointer dereference, address: 0000000000000194
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> PGD 0 P4D 0
> Oops: 0000 [#1] PREEMPT SMP NOPTI
> CPU: 1 PID: 8356 Comm: tokio-runtime-w Not tainted 6.6.104.2-4.azl3 #1
> Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS Hyper-V UEFI Release v4.1 09/28/2024
> RIP: 0010:tcm_loop_tpg_address_show+0x2e/0x50 [tcm_loop]
> ...
> Call Trace:
>  <TASK>
>  configfs_read_iter+0x12d/0x1d0 [configfs]
>  vfs_read+0x1b5/0x300
>  ksys_read+0x6f/0xf0
> ...
> 
> Cc: stable@vger.kernel.org
> Fixes: 2628b352c3d4 ("tcm_loop: Show address of tpg in configfs")
> Signed-off-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>

Reviewed-by: Allen Pais <apais@linux.microsoft.com <mailto:apais@linux.microsoft.com>>

> ---
> drivers/target/loopback/tcm_loop.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
> index c7b7da629741..01a8e349dc4d 100644
> --- a/drivers/target/loopback/tcm_loop.c
> +++ b/drivers/target/loopback/tcm_loop.c
> @@ -894,6 +894,9 @@ static ssize_t tcm_loop_tpg_address_show(struct config_item *item,
> struct tcm_loop_tpg, tl_se_tpg);
> struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba;
> 
> + if (!tl_hba->sh)
> + return -ENODEV;
> +
> return snprintf(page, PAGE_SIZE, "%d:0:%d\n",
> tl_hba->sh->host_no, tl_tpg->tl_tpgt);
> }
> -- 
> 2.49.0


  parent reply	other threads:[~2025-11-06 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 19:25 Hamza Mahfooz
2025-11-06  6:41 ` Chaitanya Kulkarni
2025-11-06 15:56 ` Allen Pais [this message]
2025-11-13  2:47 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C4A5B08B-27E4-4ACF-96E4-9351F0BFF320@linux.microsoft.com \
    --to=apais@linux.microsoft.com \
    --cc=hamzamahfooz@linux.microsoft.com \
    --cc=kanie@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=sheng@yasker.org \
    --cc=stable@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®