From: Takao Indoh <indou.takao@jp.fujitsu.com>
To: Milton Miller <miltonm@bga.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [KDUMP] Ignore spurious IPI
Date: Thu, 24 Mar 2011 17:25:18 -0400 [thread overview]
Message-ID: <C4CBEA69F94DFCindou.takao@jp.fujitsu.com> (raw)
In-Reply-To: <smp-ipi-supurious-single-kdump@mdm.bga.com>
On Thu, 24 Mar 2011 08:20:32 -0600, Milton Miller wrote:
>On Wed, 23 Mar 2011 about 18:40:12 -0000, Takao Indoh wrote:
>> Hi all,
>>
>> I found a problem that kdump(2nd kernel) sometimes hangs up. It seems
>> that system panic occurs as follows.
>..
>> (2)
>> A pending IPI from 1st kernel comes after unmasking interrupts at the
>> following point.
>>
>> asmlinkage void __init start_kernel(void)
>> {
>> (snip)
>> time_init();
>> profile_init();
>> if (!irqs_disabled())
>> printk(KERN_CRIT "start_kernel(): bug: interrupts were "
>> "enabled early\n");
>> early_boot_irqs_disabled = false;
>> local_irq_enable(); <=======================================HERE
>>
>> (3)
>> Kernel tries to handle the interrupt, but some data structures are not
>> initialized yet at this point. As a result, in the
>> generic_smp_call_function_single_interrupt(), NULL pointer dereference
>> occurs when list_replace_init() tries to access &q->list.next.
>>
>[tried to match lapic timer interrupt]
>> Any comments?
>
>So this occurs because unlike device interrupts, this vector has the action
>defined statically and no per-interrupt disable on your architecture?
I think there is not per-interrupt disable for IPI.
>If so, just initialize the data structure earlier -- change
>init_call_single_data from early_initcall to an explict call after the
>per-cpu areas are initialized.
That makes sense. I'll do this, thanks.
Thanks,
Takao Indoh
>
>milton
next prev parent reply other threads:[~2011-03-24 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 18:40 [PATCH][KDUMP] " Takao Indoh
2011-03-24 14:20 ` [KDUMP] " Milton Miller
2011-03-24 21:25 ` Takao Indoh [this message]
2011-03-25 6:45 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4CBEA69F94DFCindou.takao@jp.fujitsu.com \
--to=indou.takao@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome