From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754718AbaBRRts (ORCPT ); Tue, 18 Feb 2014 12:49:48 -0500 Received: from senator.holtmann.net ([87.106.208.187]:48388 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450AbaBRRtq convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2014 12:49:46 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: [PATCH v2] Bluetooth: allocate static minor for vhci From: Marcel Holtmann In-Reply-To: <20140218173308.GB17368@kroah.com> Date: Tue, 18 Feb 2014 09:49:41 -0800 Cc: Lucas De Marchi , "bluez mailin list (linux-bluetooth@vger.kernel.org)" , Kay Sievers , linux-kernel , Lucas De Marchi Content-Transfer-Encoding: 8BIT Message-Id: References: <1392700766-4374-1-git-send-email-lucas.demarchi@intel.com> <20140218173308.GB17368@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.1827) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lucas, >>> Commit bfacbb9 (Bluetooth: Use devname:vhci module alias for virtual HCI >>> driver) added the module alias to hci_vhci module so it's possible to >>> create the /dev/vhci node. However creating an alias without >>> specifying the minor doesn't allow us to create the node ahead, >>> triggerring module auto-load when it's first accessed. >>> >>> Starting with depmod from kmod 16 we started to warn if there's a >>> devname alias without specifying the major and minor. >>> >>> Let's do the same done for uhid, kvm, fuse and others, specifying a >>> fixed minor. In systems with systemd as the init the following will >>> happen: on early boot systemd will call "kmod static-nodes" to read >>> /lib/modules/$(uname -r)/modules.devname and then create the nodes. When >>> first accessed these "dead" nodes will trigger the module loading. >>> >>> Signed-off-by: Lucas De Marchi >>> --- >>> >>> Changes from v1: >>> - use minor=137, since 240 is reserved for local use >>> >>> We talked about using 197, but that's being used by pxa3xx-gcu, too. >> >> looks fine to me. If Kay and/or Greg want to ack it, then I take it through bluetooth-next tree. > > Acked-by: Greg Kroah-Hartman > patch has been applied to bluetooth-next tree. Regards Marcel