From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038AbWGAOes (ORCPT ); Sat, 1 Jul 2006 10:34:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751173AbWGAOes (ORCPT ); Sat, 1 Jul 2006 10:34:48 -0400 Received: from nommos.sslcatacombnetworking.com ([67.18.224.114]:7541 "EHLO nommos.sslcatacombnetworking.com") by vger.kernel.org with ESMTP id S1751038AbWGAOer (ORCPT ); Sat, 1 Jul 2006 10:34:47 -0400 In-Reply-To: <20060701102557.GA14013@lst.de> References: <9FCDBA58F226D911B202000BDBAD467306E04FF6@zch01exm40.ap.freescale.net> <1151709194.27137.2.camel@localhost.localdomain> <1151738466.27137.24.camel@localhost.localdomain> <20060701102557.GA14013@lst.de> Mime-Version: 1.0 (Apple Message framework v750) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: Benjamin Herrenschmidt , Paul Mackerras , "linux-kernel@vger.kernel.org mailing list" , linuxppc-dev list , Pantelis Antoniou Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] powerpc:Fix rheap alignment problem Date: Sat, 1 Jul 2006 09:34:45 -0500 To: Christoph Hellwig X-Mailer: Apple Mail (2.750) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - nommos.sslcatacombnetworking.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.crashing.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Jul 1, 2006, at 5:25 AM, Christoph Hellwig wrote: > On Sat, Jul 01, 2006 at 05:21:06PM +1000, Benjamin Herrenschmidt > wrote: >> On Sat, 2006-07-01 at 14:35 +0800, Linux powerpc wrote: >>> Yes, it was used for allocating dual port RAM for CPM. And now >>> we are >>> adding QE support to powerpc arch which need to use rheap(QE is next >>> generation for CPM). Please see the patches I >>> just posted for 8360epb support. Moreover, previous CPM support is >>> adding to powerpc arch too. >> >> Ok, well, I don't have anything specifically against that code, I was >> just wondering if it may not duplicate something we already have (yet >> another space allocator basically)... > > Yepp. Without looking at the rheap allocator in deatail, any reason > it can't use lib/genalloc.c? Doing a quick glance at lib/genalloc.c I dont see any reason we couldn't use it. However, Panto will know best, since he wrote rheap. - k