From: hayeswang <hayeswang@realtek.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net-next 1/2] r8169: support RTL8106E
Date: Wed, 4 Jul 2012 17:02:17 +0800 [thread overview]
Message-ID: <C4FBD4FA06A3458594FEA8117B2274B6@realtek.com.tw> (raw)
In-Reply-To: <20120703110101.GA4779@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
[...]
> > +#define FIRMWARE_8106E_1 "rtl_nic/rtl8106e-1.fw"
>
> I did not notice it. Was it submitted ?
>
I don't submit it yet.
> It was obviously not required for testing :o)
>
> > @@ -1933,6 +1941,8 @@ static void
> rtl8169_get_mac_version(struct rtl8169_private *tp,
> > { 0x7c800000, 0x30000000, RTL_GIGA_MAC_VER_11 },
> >
> > /* 8101 family. */
> > + { 0x7cf00000, 0x44900000, RTL_GIGA_MAC_VER_39 },
> > + { 0x7c800000, 0x44800000, RTL_GIGA_MAC_VER_39 },
> > { 0x7c800000, 0x44000000, RTL_GIGA_MAC_VER_37 },
> > { 0x7cf00000, 0x40b00000, RTL_GIGA_MAC_VER_30 },
> > { 0x7cf00000, 0x40a00000, RTL_GIGA_MAC_VER_30 },
>
> Realtek's 1.022.00 8101 driver only maps { 0x7c800000; 0x44800000 } to
> a generic device - if at all - and it maps { 0x7cf00000; 0x44800000 }
> to a different chipset (namely CFG_METHOD_15 where RTL_GIGA_MAC_VER_39
> is CFG_METHOD_16).
>
> Why should both drivers diverge ?
>
Our PMs say only 0x44900000 would have mass production. Besides, you could use
the same setting for both of them.
Best Regards,
Hayes
next prev parent reply other threads:[~2012-07-04 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 10:34 [PATCH " Hayes Wang
2012-06-29 10:34 ` [PATCH net-next 2/2] r8169: support RTL8168G Hayes Wang
2012-06-29 13:51 ` Francois Romieu
2012-07-02 7:27 ` hayeswang
2012-06-29 13:50 ` [PATCH net-next 1/2] r8169: support RTL8106E Francois Romieu
2012-07-02 9:23 ` [PATCH v2 " Hayes Wang
2012-07-02 9:23 ` [PATCH v2 net-next 2/2] r8169: support RTL8168G Hayes Wang
2012-07-04 22:04 ` Francois Romieu
2012-07-05 0:51 ` Joe Perches
2012-07-06 15:20 ` Francois Romieu
2012-07-06 15:37 ` Joe Perches
2012-07-06 7:57 ` hayeswang
2012-07-06 15:20 ` Francois Romieu
2012-07-03 11:01 ` [PATCH v2 net-next 1/2] r8169: support RTL8106E Francois Romieu
2012-07-04 9:02 ` hayeswang [this message]
2012-07-09 6:48 ` [PATCH " David Miller
2012-07-09 10:12 ` Francois Romieu
2012-07-09 21:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4FBD4FA06A3458594FEA8117B2274B6@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®