From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To: Punit Vara <punitvara@gmail.com>
Cc: JBottomley@odin.com, don.brace@pmcs.com, storagedev@pmcs.com,
iss_storagedev@hp.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc
Date: Fri, 23 Oct 2015 18:26:21 -0500 [thread overview]
Message-ID: <C55884B0-E8D4-4EE2-AB46-40A871F8A073@linux.vnet.ibm.com> (raw)
In-Reply-To: <1445630633-14209-2-git-send-email-punitvara@gmail.com>
Hi Punit,
Aren't you missing the removal of the memset() as part of this conversion?
-matt
> On Oct 23, 2015, at 3:03 PM, Punit Vara <punitvara@gmail.com> wrote:
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 36bf58b..422c800 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
next prev parent reply other threads:[~2015-10-23 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 20:03 [PATCH 0/2] Fix warning by coccicheck Punit Vara
2015-10-23 20:03 ` [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara
2015-10-23 23:26 ` Matthew R. Ochs [this message]
2015-10-25 9:17 ` punit vara
2015-10-23 20:03 ` [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure Punit Vara
2015-10-23 23:27 ` Matthew R. Ochs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C55884B0-E8D4-4EE2-AB46-40A871F8A073@linux.vnet.ibm.com \
--to=mrochs@linux.vnet.ibm.com \
--cc=JBottomley@odin.com \
--cc=don.brace@pmcs.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=punitvara@gmail.com \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®